Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 7 May 2021 10:04:13 -0400
From:   Peter Xu <peterx@redhat.com>
To:     John Hubbard <jhubbard@nvidia.com>
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        Hugh Dickins <hughd@google.com>, Jan Kara <jack@suse.cz>,
        Kirill Shutemov <kirill@shutemov.name>,
        Jason Gunthorpe <jgg@nvidia.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Kirill Tkhai <ktkhai@virtuozzo.com>,
        Michal Hocko <mhocko@suse.com>,
        Oleg Nesterov <oleg@redhat.com>, Jann Horn <jannh@google.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Matthew Wilcox <willy@infradead.org>,
        Andrea Arcangeli <aarcange@redhat.com>
Subject: Re: [PATCH 1/3] mm/gup_benchmark: Support threading
Message-ID: <YJVI3QAqT2TruTjq@t490s>
References: <20210506232537.165788-1-peterx@redhat.com>
 <20210506232537.165788-2-peterx@redhat.com>
 <a631bb81-a8a7-0423-4e7c-e0cf213e932b@nvidia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <a631bb81-a8a7-0423-4e7c-e0cf213e932b@nvidia.com>
Precedence: bulk

On Thu, May 06, 2021 at 09:37:37PM -0700, John Hubbard wrote:
> On 5/6/21 4:25 PM, Peter Xu wrote:
> > Add a new parameter "-j N" to support concurrent gup test.
> 
> I had a long-standing personal TODO item that said, "decide if it's
> worth it, to add pthread support to gup_test". So now, at least one
> other person has decided that it *is* worth it, and you've also written
> the patch. OK, then. Sweet! :)
> 
> This looks correct to me. I have a couple of minor comments below, but
> either way you can add:

I'll address them.

> 
> Reviewed-by: John Hubbard <jhubbard@nvidia.com>

Thanks!

-- 
Peter Xu