Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 7 May 2021 16:36:02 +0200
From:   Andreas Kemnade <andreas@kemnade.info>
To:     Vignesh Raghavendra <vigneshr@ti.com>
Cc:     Grygorii Strashko <grygorii.strashko@ti.com>,
        Rob Herring <robh+dt@kernel.org>, <linux-omap@vger.kernel.org>,
        <linux-i2c@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>,
        Linux ARM Mailing List <linux-arm-kernel@lists.infradead.org>,
        Tony Lindgren <tony@atomide.com>, Nishanth Menon <nm@ti.com>
Subject: Re: [PATCH v2] dt-bindings: i2c: Move i2c-omap.txt to YAML format
Message-ID: <20210507163602.219894f4@aktux>
In-Reply-To: <429a740a-c2b9-1cf8-ed2b-0fb7b1bea422@ti.com>
References: <20210506140026.31254-1-vigneshr@ti.com>
        <f7570cb4-8c21-2fa5-bd26-1388f2a4bd6b@ti.com>
        <429a740a-c2b9-1cf8-ed2b-0fb7b1bea422@ti.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Fri, 7 May 2021 19:45:45 +0530
Vignesh Raghavendra <vigneshr@ti.com> wrote:

> On 5/7/21 12:24 PM, Grygorii Strashko wrote:
> > 
> > 
> > On 06/05/2021 17:00, Vignesh Raghavendra wrote:  
> >> Convert i2c-omap.txt to YAML schema for better checks and documentation.
> >>
> >> Following properties were used in DT but were not documented in txt
> >> bindings and has been included in YAML schema:
> >> 1. Include ti,am4372-i2c compatible
> >> 2. Include dmas property used in few OMAP dts files  
> > 
> > The DMA is not supported by i2c-omap driver, so wouldn't be better to
> > just drop dmas from DTBs to avoid confusions?
> > It can be added later.
> >   
> 
> Will do.. I will also send patches dropping dmas from dts that currently
> have them populated.
> 
hmm, we have
- DO attempt to make bindings complete even if a driver doesn't support some
  features. For example, if a device has an interrupt, then include the
  'interrupts' property even if the driver is only polled mode.

in Documentation/devicetree/bindings/writing-bindings.rst
Shouln't the dma stay there if the hardware supports it? Devicetree
should describe the hardware not the driver if I understood things
right.

Regards,
Andreas