Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: wcheng=codeaurora.org@mg.codeaurora.org
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org D1131C4338A
Subject: Re: [PATCH] usb: dwc3: gadget: Return success always for kick
 transfer in ep queue
To:     Felipe Balbi <balbi@kernel.org>, gregkh@linuxfoundation.org
Cc:     linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
        Thinh.Nguyen@synopsys.com, jackp@codeaurora.org
References: <1620369287-27492-1-git-send-email-wcheng@codeaurora.org>
 <87bl9mhgee.fsf@kernel.org>
From:   Wesley Cheng <wcheng@codeaurora.org>
Message-ID: <bb9d37e3-dce4-7b71-4dcd-97e2916be7de@codeaurora.org>
Date:   Fri, 7 May 2021 10:38:48 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.1
MIME-Version: 1.0
In-Reply-To: <87bl9mhgee.fsf@kernel.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 5/7/2021 5:34 AM, Felipe Balbi wrote:
> Wesley Cheng <wcheng@codeaurora.org> writes:
> 
>> If an error is received when issuing a start or update transfer
>> command, the error handler will stop all active requests (including
>> the current USB request), and call dwc3_gadget_giveback() to notify
>> function drivers of the requests which have been stopped.  Avoid
>> returning an error for kick transfer during EP queue, to remove
>> duplicate cleanup operations on the request being queued.
>>
>> Signed-off-by: Wesley Cheng <wcheng@codeaurora.org>

Hi Felipe,
> 
> do you want to add a Fixes here? :-)
> 
Sure, will do!

> We should probably Cc stable too.
> 
Got it.

Thanks
Wesley Cheng

-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project