From: Dmitry Torokhov <dtor@insightbb.com>
To: =?utf-8?q?N=C3=A9meth_M=C3=A1rton?= <nm127@freemail.hu>
Subject: Re: [patch] input: function call order in serio_exit()
Date: Sun, 22 Oct 2006 23:15:47 -0400
User-Agent: KMail/1.9.3
Cc: linux-input@atrey.karlin.mff.cuni.cz, linux-kernel@vger.kernel.org
References: <453B921D.80008@freemail.hu>
In-Reply-To: <453B921D.80008@freemail.hu>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="utf-8"
Content-Transfer-Encoding: 8BIT
Content-Disposition: inline
Message-Id: <200610222315.48592.dtor@insightbb.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 884
Lines: 28

On Sunday 22 October 2006 11:45, Németh Márton wrote:
> Hi,
> 
> the order of the bus registration and the kthread start was changed
> between linux kernel 2.6.17.11 and 2.6.18. The order is now first
> register the bus and then start the kthread. The serio_exit() left
> unchanged.
> 
> I think that the order of the function calls in serio_exit() should also
> be changed: first stop the kthread and then unregister the bus.
> 
> What do you think?
> 

Hi,

It really does not matter - if bus is unregistered that means the there
are no drivers using it and so noone can submit new requests to kseriod.

I'd leave it as is.

-- 
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/