Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751411AbWJWDmT (ORCPT ); Sun, 22 Oct 2006 23:42:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751404AbWJWDmS (ORCPT ); Sun, 22 Oct 2006 23:42:18 -0400 Received: from dsl027-180-168.sfo1.dsl.speakeasy.net ([216.27.180.168]:14026 "EHLO sunset.davemloft.net") by vger.kernel.org with ESMTP id S1751401AbWJWDmS (ORCPT ); Sun, 22 Oct 2006 23:42:18 -0400 Date: Sun, 22 Oct 2006 20:42:20 -0700 (PDT) Message-Id: <20061022.204220.78710782.davem@davemloft.net> To: shemminger@osdl.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] netpoll: use sk_buff_head for txq From: David Miller In-Reply-To: <20061020153027.3bed8c86@dxpl.pdx.osdl.net> References: <20061020134826.75dd1cba@freekitty> <20061020.140149.125893169.davem@davemloft.net> <20061020153027.3bed8c86@dxpl.pdx.osdl.net> X-Mailer: Mew version 4.2 on Emacs 21.4 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 810 Lines: 24 From: Stephen Hemminger Date: Fri, 20 Oct 2006 15:30:27 -0700 > + spin_lock_irqsave(&netpoll_txq.lock, flags); > + for (skb = (struct sk_buff *)netpoll_txq.next; > + skb != (struct sk_buff *)&netpoll_txq; skb = next) { > + next = skb->next; > + if (skb->dev == dev) > + skb_unlink(skb, &netpoll_txq); > + } > + spin_unlock_irqrestore(&netpoll_txq.lock, flags); > } All SKBs removed here will be leaked, nothing frees them up. Since #2 and #3 depend upon this patch, I'll hold off on those until you fix this bug. Thanks. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/