Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sat, 8 May 2021 02:41:50 +0200
From:   Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= 
        <marmarek@invisiblethingslab.com>
To:     Luca Fancellu <luca.fancellu@arm.com>
Cc:     Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org,
        linux-kernel@vger.kernel.org,
        Boris Ostrovsky <boris.ostrovsky@oracle.com>,
        Stefano Stabellini <sstabellini@kernel.org>,
        stable@vger.kernel.org
Subject: Re: [PATCH] xen/gntdev: fix gntdev_mmap() error exit path
Message-ID: <YJXeTy0lNWvSMnZH@mail-itl>
References: <20210423054038.26696-1-jgross@suse.com>
 <467B8109-C829-4755-8398-196E50090898@arm.com>
 <9cb9bd6c-8185-9741-31b9-8f6baf3848a3@suse.com>
 <92E0F915-499C-4471-B0C9-336494C5E31D@arm.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="pOlv8fsOYh8hH7v+"
Content-Disposition: inline
In-Reply-To: <92E0F915-499C-4471-B0C9-336494C5E31D@arm.com>
Precedence: bulk


--pOlv8fsOYh8hH7v+
Content-Type: text/plain; protected-headers=v1; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Sat, 8 May 2021 02:41:50 +0200
From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
To: Luca Fancellu <luca.fancellu@arm.com>
Cc: Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <sstabellini@kernel.org>, stable@vger.kernel.org
Subject: Re: [PATCH] xen/gntdev: fix gntdev_mmap() error exit path

On Fri, Apr 23, 2021 at 08:04:57AM +0100, Luca Fancellu wrote:
> > On 23 Apr 2021, at 08:00, Juergen Gross <jgross@suse.com> wrote:
> > On 23.04.21 08:55, Luca Fancellu wrote:
> >>> On 23 Apr 2021, at 06:40, Juergen Gross <jgross@suse.com> wrote:
> >>>=20
> >>> Commit d3eeb1d77c5d0af ("xen/gntdev: use mmu_interval_notifier_insert=
")
> >>> introduced an error in gntdev_mmap(): in case the call of
> >>> mmu_interval_notifier_insert_locked() fails the exit path should not
> >>> call mmu_interval_notifier_remove(), as this might result in NULL
> >>> dereferences.
> >>>=20
> >>> One reason for failure is e.g. a signal pending for the running
> >>> process.
> >>>=20
> >>> Fixes: d3eeb1d77c5d0af ("xen/gntdev: use mmu_interval_notifier_insert=
")
> >>> Cc: stable@vger.kernel.org
> >>> Reported-by: Marek Marczykowski-G=C3=B3recki <marmarek@invisiblething=
slab.com>
> >>> Tested-by: Marek Marczykowski-G=C3=B3recki <marmarek@invisiblethingsl=
ab.com>
> >>> Signed-off-by: Juergen Gross <jgross@suse.com>

(...)

> Right, thanks, seems good to me.
>=20
> Reviewed-by: Luca Fancellu <luca.fancellu@arm.com>

Can somebody ack this fix please?=20

--=20
Best Regards,
Marek Marczykowski-G=C3=B3recki
Invisible Things Lab

--pOlv8fsOYh8hH7v+
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmCV3k4ACgkQ24/THMrX
1yxJTwf+MztgRk40NrBaqMG3/vvS/xaYpsHaX6aDvKJn6O+2s6bkhNejJURDM7QW
B048xcn16B4UTKoIr/6BuToivQKKaQyuX3Da8XstMYDJc6H70Eisf6o2YX33EvZS
k0F+R6dnCKHb9DVWltZs4onpAAUlnKeaYIpu+dgsCISX9UoOo7ogmNANyLtZEYz+
BvzFd5vWrF5I6KOjVBxMSF0ENGi9y+YYelKfCYYe0E6DM1059WmxAuzRlc+PJv6j
9qGS46t0JkbVlIgV7O36Lw7/m25OvoxLBBb/ImH5yBo+uNMmCBUavR75U/9gInE3
RN3X65Zqr8gCKtldPPUG5Ro2bF1AcQ==
=FcB0
-----END PGP SIGNATURE-----

--pOlv8fsOYh8hH7v+--