Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp927046pxj; Sat, 8 May 2021 02:51:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwm4X81Xyvx/7rZEypRsdx6e2l0pt7x9KlWlo2oG/ug4E1EBWzjbD4mA5gRZ/05uoAPBKpT X-Received: by 2002:a17:906:d28e:: with SMTP id ay14mr14972164ejb.33.1620467475462; Sat, 08 May 2021 02:51:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620467475; cv=none; d=google.com; s=arc-20160816; b=q/sTpH9HRvDiL+FItSAOkhNRZtWT4M8P7AYeN0ZlSzzf6/333sYu6LIaiQHn/8FD+b XPLLAI3RZimhNU+XO/61NH2xAKcOdnlgMQLerNTUbYz4zHjZuDdDWifFL1K4HzRRSLgu d3rryzosPJ6c8IULCsAFQyxEqbsEUlo8cc/JX6MiecFLCnRUVRc8TBH+WJeWv++OA9bQ YxyaJ3IA4MAWlRH8+0Ec7LaYVCfDyjIog1v7+iLmA9y9k/diYIveSng0Q3Kx1uyCElLU Sn2RVS+7MuyL/ffyD4rj3KuiQxxzDsaALiKeElFmXCNNdAHEyC6wDTN45hPfPe0uCisW 8acw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=IQqVHs76XhjtZDzkptDb3pKsbswt7BT6LhPyiwkXRzY=; b=S0OqqLvG5693Zzw8VAenUcaJq/GwTZEMtZm3efAM0JYXQJjKFJs6S50M0DX9+lsGaj /dTuTNsnHovQgTwITRsiuBZmMz/R2WSVxBR8jD+qHn5k3HAqp+ajar3k3PwYIl+jEXx1 7R+1Tyyf8oeslLUC1p/ZK/mZJvgn9Odz5H+7XPH0psbJntFVWmITZUVkFeZp3BBi8LAs SrqblTqnUtbUwSSyf6kt4MRWMcgb045hbQC7mDH35B5SXYXo0ih/pH20S1kW5kNO1Zic S6K1CEvikDIwjHFPUnvg8jInyTGz46wDguaVEFeklkvzT3AeIqtWA7eAKl1k2vPz/Jc1 u/gg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=Szlf795M; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z5si7386303edc.126.2021.05.08.02.50.46; Sat, 08 May 2021 02:51:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=Szlf795M; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230387AbhEHJsw (ORCPT + 99 others); Sat, 8 May 2021 05:48:52 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:53096 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229583AbhEHJsw (ORCPT ); Sat, 8 May 2021 05:48:52 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 1489jPa3086509; Sat, 8 May 2021 09:47:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=IQqVHs76XhjtZDzkptDb3pKsbswt7BT6LhPyiwkXRzY=; b=Szlf795MhekMLmqLTpRi1aHzINq40fW+DrpUVcZtyrCsGT0FIPwt7zBXCT1lrogPt0cW 6Ldiqb4czEKF4SgwR4E5jF0moi/rxGGB/p/n3hXPZfTLEyo4e3Nv1EgkkBHDa6opf24D ZeT7DVYA/0ayaZ1Lnlg92zvHw37Ko4BTasONnWCP4CfJ8fUlVMqxiqnj8ql+tjxW45V2 PuK7TBD6s/HvA5HV+2p7w2Vx/5LC2esuwHizhUfUFWhLp4yHj3Qk80+K6gc7Ebd+w2/9 0JLeBtoevoShaqEZAT2e08NA406mqch+xTSHF4XwdSPkqIfDKxqSq58jxLFLdnssHG3D Ow== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by userp2120.oracle.com with ESMTP id 38dk9n89tc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 08 May 2021 09:47:38 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 1489jeEe141687; Sat, 8 May 2021 09:47:37 GMT Received: from pps.reinject (localhost [127.0.0.1]) by aserp3030.oracle.com with ESMTP id 38dgpcfekn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 08 May 2021 09:47:37 +0000 Received: from aserp3030.oracle.com (aserp3030.oracle.com [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 1489la0j145113; Sat, 8 May 2021 09:47:37 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserp3030.oracle.com with ESMTP id 38dgpcfej4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 08 May 2021 09:47:36 +0000 Received: from abhmp0005.oracle.com (abhmp0005.oracle.com [141.146.116.11]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 1489lalM007047; Sat, 8 May 2021 09:47:36 GMT Received: from kadam (/102.36.221.92) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sat, 08 May 2021 02:47:35 -0700 Date: Sat, 8 May 2021 12:47:29 +0300 From: Dan Carpenter To: Pavle Rohalj Cc: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 08/49] staging: sm750fb: Update enum values in dpms to snake case Message-ID: <20210508094729.GK1955@kadam> References: <16693e7cc62f84ea1ec34b7d5cbd77c4cd1965e8.1617776878.git.pavle.rohalj@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <16693e7cc62f84ea1ec34b7d5cbd77c4cd1965e8.1617776878.git.pavle.rohalj@gmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-ORIG-GUID: v8H7VetVFFfdHibY98cHgUyDGo6SaQDX X-Proofpoint-GUID: v8H7VetVFFfdHibY98cHgUyDGo6SaQDX X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9977 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 phishscore=0 adultscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 lowpriorityscore=0 malwarescore=0 priorityscore=1501 clxscore=1015 bulkscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000 definitions=main-2105080070 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 06, 2021 at 11:36:16PM -0700, Pavle Rohalj wrote: > Fix "Avoid CamelCase" checkpatch.pl checks for values in > enum dpms. > > Signed-off-by: Pavle Rohalj > --- > drivers/staging/sm750fb/ddk750_power.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/sm750fb/ddk750_power.h b/drivers/staging/sm750fb/ddk750_power.h > index 7002567a47d2..4756db1ccb9c 100644 > --- a/drivers/staging/sm750fb/ddk750_power.h > +++ b/drivers/staging/sm750fb/ddk750_power.h > @@ -3,10 +3,10 @@ > #define DDK750_POWER_H__ > > enum dpms { > - crtDPMS_ON = 0x0, > - crtDPMS_STANDBY = 0x1, > - crtDPMS_SUSPEND = 0x2, > - crtDPMS_OFF = 0x3, > + CRT_DPMS_ON = 0x0, > + CRT_DPMS_STANDBY = 0x1, > + CRT_DPMS_SUSPEND = 0x2, > + CRT_DPMS_OFF = 0x3, > }; These must be unused. Delete. regards, dan carpenter