Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp954823pxj; Sat, 8 May 2021 03:48:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzU1rs9oZPhIDD/P252FcP2TUaXwlu2+/nPXLQJJX5wack2RSfmQbiTz0UKtIW52Jfm4apc X-Received: by 2002:a05:6402:1859:: with SMTP id v25mr18139197edy.150.1620470883317; Sat, 08 May 2021 03:48:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620470883; cv=none; d=google.com; s=arc-20160816; b=OV5Yj1H9nRJKYsU3SVHkIach1/NEECFgIqZysktZ9sf4zLjc6GmsqAl5imM/ytGWvo 7SmtXyM4oJsNa1NFvEMseu+khHy1rJB22e96gyzTxEVeNcT0DdimpG7Tocjd6WJwKfo7 VRsRYZH5RJ93tig+9EfUdzOsNl8qmgFQW6vCDnp+IFZj8hs2JfkBIii+i6WqM5RpICzz ypYNkfmKBt22Qa5KP5FOHYf7JtzlwZ3XUHCoT2Rze5FjW9sZFGijxKD6hMGxBWWEl8md kxYykWiRM0Ip9jF0e6ZJNnsK32hqJS1tiTJsU0v8VQcDI2Ea27Xk7spD/SiuwkXM8zc/ sw5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=fGVlQQDdWumLfeXe3z1WGqfndZwZsvCBdpE1r55hfR0=; b=cz2Of/HJUFsKcRjDV9ngzcz1YgCjxhr3WI17uKTuopOEL05R/mN+kImLn2yAlHXddz DYumF3IGlWbT28jiI+EfTbLnPoePcIVYCavYq3GBG8jVlvIdMZEx7Vi8sl3CXnt2Hz5r SfoiRI1a8XxoHOjaMNU9rzJq6Mp/l+gjixjE/T5ur6mvLDI7gzUJ2ZrmjGQ+XJ5GBohG CCtkKKHP6N9se91L0Md/onqUFZ718LXGjYe47CaF8Qetl/j101cV0+6IN5PfNylcrK3E mY+fYoLjdB+CgPINpvxlGWer1eOvrkqMbJQqRzgU4cBKpyjmfs6b4lE8bA2+EfDYKg8F rsUg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g28si6349928edf.443.2021.05.08.03.47.39; Sat, 08 May 2021 03:48:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230405AbhEHKmb (ORCPT + 99 others); Sat, 8 May 2021 06:42:31 -0400 Received: from out30-130.freemail.mail.aliyun.com ([115.124.30.130]:49006 "EHLO out30-130.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230234AbhEHKmb (ORCPT ); Sat, 8 May 2021 06:42:31 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R151e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04394;MF=jiapeng.chong@linux.alibaba.com;NM=1;PH=DS;RN=6;SR=0;TI=SMTPD_---0UY8aVeP_1620470483; Received: from j63c13417.sqa.eu95.tbsite.net(mailfrom:jiapeng.chong@linux.alibaba.com fp:SMTPD_---0UY8aVeP_1620470483) by smtp.aliyun-inc.com(127.0.0.1); Sat, 08 May 2021 18:41:28 +0800 From: Jiapeng Chong To: mark@fasheh.com Cc: jlbec@evilplan.org, joseph.qi@linux.alibaba.com, ocfs2-devel@oss.oracle.com, linux-kernel@vger.kernel.org, Jiapeng Chong Subject: [PATCH] ocfs2: Reomve err less than zero check Date: Sat, 8 May 2021 18:41:21 +0800 Message-Id: <1620470481-31597-1-git-send-email-jiapeng.chong@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The check for err < 0 is always false because err is an enum and can never be less than zero. Clean up the following coccicheck warning: fs/ocfs2/dlm/dlmdebug.c:222 dlm_errname() warn: unsigned 'err' is never less than zero. fs/ocfs2/dlm/dlmdebug.c:214 dlm_errmsg() warn: unsigned 'err' is never less than zero. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- fs/ocfs2/dlm/dlmdebug.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/ocfs2/dlm/dlmdebug.c b/fs/ocfs2/dlm/dlmdebug.c index d442cf5..817914d 100644 --- a/fs/ocfs2/dlm/dlmdebug.c +++ b/fs/ocfs2/dlm/dlmdebug.c @@ -211,7 +211,7 @@ void dlm_print_one_lock(struct dlm_lock *lockid) const char *dlm_errmsg(enum dlm_status err) { - if (err >= DLM_MAXSTATS || err < 0) + if (err >= DLM_MAXSTATS) return dlm_errmsgs[DLM_MAXSTATS]; return dlm_errmsgs[err]; } @@ -219,7 +219,7 @@ const char *dlm_errmsg(enum dlm_status err) const char *dlm_errname(enum dlm_status err) { - if (err >= DLM_MAXSTATS || err < 0) + if (err >= DLM_MAXSTATS) return dlm_errnames[DLM_MAXSTATS]; return dlm_errnames[err]; } -- 1.8.3.1