Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   David Laight <David.Laight@ACULAB.COM>
To:     'Arnd Bergmann' <arnd@kernel.org>,
        "linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>
CC:     Linus Torvalds <torvalds@linux-foundation.org>,
        Vineet Gupta <vgupta@synopsys.com>,
        Arnd Bergmann <arnd@arndb.de>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [RFC 12/12] asm-generic: simplify asm/unaligned.h
Thread-Topic: [RFC 12/12] asm-generic: simplify asm/unaligned.h
Thread-Index: AQHXQ44THJRTTBSqUkSVDsewAlm13qrZaWdA
Date:   Sat, 8 May 2021 11:03:20 +0000
Message-ID: <0b599cc80612436bb8d688fa2ad1dc34@AcuMS.aculab.com>
References: <20210507220813.365382-1-arnd@kernel.org>
 <20210507220813.365382-13-arnd@kernel.org>
In-Reply-To: <20210507220813.365382-13-arnd@kernel.org>
Accept-Language: en-GB, en-US
MIME-Version: 1.0
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Precedence: bulk

From: Arnd Bergmann
> Sent: 07 May 2021 23:08
> 
> The get_unaligned()/put_unaligned() implementations are much more complex
> than necessary, now that all architectures use the same code.
> 
...
> +#define __get_unaligned_t(type, ptr) ({						\
> +	const struct { type x; } __packed *__pptr = (typeof(__pptr))(ptr);	\
> +	__pptr->x; 								\
> +})

I thought gcc was likely to track through the alignment of the
variable holding the source pointer (through any (void *) casts
implied by inlined function calls) through to the pointer used
for the actual access - so it would tend to issue a single
instruction that assumed an aligned address.

I know that has caused grief trying to copy unaligned data
to an aligned structure.

Possibly adding:
	asm ("" :: "+r" (__pptr)) );
in the middle stops that assumption without generating any code.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)