Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp1012134pxj; Sat, 8 May 2021 05:24:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyT+EMUoQ+QyrXbw/c10j+3O707fVLveQ2IMRD5rwZlI3B37pd0+a/AbQr82awcBbxvOD3I X-Received: by 2002:a05:6402:3553:: with SMTP id f19mr17280526edd.167.1620476644025; Sat, 08 May 2021 05:24:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620476644; cv=none; d=google.com; s=arc-20160816; b=o0SAIh5YQRt6+zDFHqlV62BJZDM8a4hn75J6/w2eSaJpznKmO+YyWeA+c+TIVwYEJH XvriSAKznuUeMMzr8LcN9RaGyiPCnk9SG+ymxj3dCcE2SzfHzn5hqMqDg4XFPeTDj/bX UQ5gjKmyJL95Z/5dV3rrZ9c3NtZzZ1+keQKo6kImiIA2NsEV+1bly9d1otYbyytbRfAD GD1Chxv0KyL7FeE+9Y6cPWhZawafVRI7nbgfTKlGfLXs5zmBbEAy0+iO6YVH1CZ/hZYE EVPkGsQco2kqVe7z3vS4M3g1a7NXy5EZJoEDwVOJd3dEkHQ5a09MCGszjL0ZkmyHqaHW noxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-disposition:mime-version:message-id :subject:cc:to:from:date:sender:dkim-signature; bh=uifGGALbd64vKa+6VH1gTKAaHjCszIAApvtYp7NtBKI=; b=NN38RKltff/d0I/92zJnc1iVkxTreuvFMnIWEICvf8K3uc2RY1LFbYTZnQzbk+dbS7 OdHy+00mRkCcJl6e6c5IOzp1yb+h/C468vjpXuMHBg1NLiL7KfVgu57CF1ql1ZyG1LqZ n0EybvsVMnRNebO7iyCMsfTQScURnMzydxU+f7oGa4LQa2fr82d34Ii+ZFPiBqSoqi/a VZ6yEzFg2g77ACqVYDLxWSr5LJOBBS/8K7RJyDw7rouhphMZZpV6uj4q0z8p2GJAQgAe Z4c8030KdSG97k+/ESSMwkR57kRIHGcekL6HuDS9I/GHCPUbj/j/caoLRlYWBqhB9VaD qDlQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=AYh2Wxg2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cw1si7768940ejb.544.2021.05.08.05.23.13; Sat, 08 May 2021 05:24:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=AYh2Wxg2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230508AbhEHMWg (ORCPT + 99 others); Sat, 8 May 2021 08:22:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60144 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230419AbhEHMWf (ORCPT ); Sat, 8 May 2021 08:22:35 -0400 Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8940BC061574; Sat, 8 May 2021 05:21:34 -0700 (PDT) Received: by mail-ed1-x52e.google.com with SMTP id bf4so13354838edb.11; Sat, 08 May 2021 05:21:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:mime-version :content-disposition; bh=uifGGALbd64vKa+6VH1gTKAaHjCszIAApvtYp7NtBKI=; b=AYh2Wxg2uElTEfhkThiAV6IK3p5C3DFx6wX+5Yv5xiQwazloMMCHSI5pXFcOKFkJdh PzDlbeWnBLwfGQJcsfCFOqvnsOifNeP3gPKEbwTJi2nmtf15NxpjiIu3m5aeGzrVcOMi JsBoMO1TSupwEPWIDwv/C8Umuaq2MDFFDReqTTqm7lLf9TVOexT8Pf/XYrvW0t0rWF/+ YSSlVPxOAqvgUBcxb7SpVoLkxHUYAZvBBQYIWJKxfbcmqu4Okg1qXVVI/Iforg/xtLUh DeU7bXxn2HU3vr76Z+GZq2hfz5PaKBVYWzl4AuA7H1W2HdROPcKpo9SXbHV3lD3gJMPq TrZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :mime-version:content-disposition; bh=uifGGALbd64vKa+6VH1gTKAaHjCszIAApvtYp7NtBKI=; b=LyEKb1meOwBVpis34wNkK50z3KGOQNrbTRTpSA5JOfwRt9YVqPZLNLitQZj1nAs5QK VTFSKnAHu7Ts5MOz1NuUVtM2bzHXOWAdBnV5/MFjGp/Utzpo/yPIS7QzV/JEj3B9+Q2E +G58d9WOLQov96atLqfmGWTldw7cAt9gZKI0TxryxI6ng6B3TM49eO4RQ9TR2ecRzbyk HgufJ/B1UdPsqubV6L689vC9ZfFxvXMW7O5jgJ/7iF3u49HNNs0ZJ+kMuH+aWS3AbIyD 5iG/m7BmRwNonXpLayI3VgFg7cIRvXGkYLHAKo4O9iyzXCMuSNiReEa3fotL6AjWv/YI X1RA== X-Gm-Message-State: AOAM53186ysBvZBKUqEDJqryJSVD2ewAABYjZzg2S5LewNfu+nGlp0xT IxYIYtjy3vHI31kww9gbZfpqPcTBjha2qOAP X-Received: by 2002:aa7:c510:: with SMTP id o16mr17552331edq.310.1620476493325; Sat, 08 May 2021 05:21:33 -0700 (PDT) Received: from eldamar (80-218-24-251.dclient.hispeed.ch. [80.218.24.251]) by smtp.gmail.com with ESMTPSA id s2sm6408210edu.89.2021.05.08.05.21.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 May 2021 05:21:32 -0700 (PDT) Sender: Salvatore Bonaccorso Date: Sat, 8 May 2021 14:21:31 +0200 From: Salvatore Bonaccorso To: coproscefalo@gmail.com, hdegoede@redhat.com, mgross@linux.intel.com Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: platform/x86: toshiba_haps: Missing newline after debug printing of received event Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi A verly long time ago in Debian it was reported that in the toshiba_haps driver, there is a missing newline in the printing of the recieved events. See https://bugs.debian.org/799193 In baae5f91577a ("platform/x86: toshiba_haps: Change logging level from info to debug") the logging level was changed from info to debug, and so less to hit. But looking from the code we still have: pr_debug("Received event: 0x%x", event); in the toshiba_haps_notify function. Regards, Salvatore