Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp1101200pxj; Sat, 8 May 2021 07:42:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz8FPmThi8bS0tih+Kni0J7d1unrVIaL8bOZ0jDNGClrsB8Prhieq8m09k+7L2gaV5HWrZh X-Received: by 2002:a50:eb82:: with SMTP id y2mr18288193edr.190.1620484975324; Sat, 08 May 2021 07:42:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620484975; cv=none; d=google.com; s=arc-20160816; b=ad+q3aA37TMfB4ptx6ByeAtxZZEDgzsTjYd0L12NdxrtXfDVEbZ6crqdC6qmxkCaI3 3qpYhPtGs7mfzhILyo1N2NqXKK2NPnordAVlGbt/vDuVBUn06X7b1PlwfSeFqvy2Z/nJ CGXJNxLCoZg51sHWp6F5qNIFtSUKAMKaBInE9w1bqtKi5UF40XagV1MiUPHoZ1UADHNV Qaf/Z/j6DCxquVl8XnoGaH1mIumQiLK6H1IWcoT4hCX1UbO5LR/v3/fjk3vWJGkhqCuW eP+BcBwLhAX7OuyOfXfCnKkruIqrADd8plVBa61QGKulQedbE1vATnob0ZJHXN4s8dHD aAWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=MZYaBypPGzWypcDz+RJ/92Ib8rkc/cBWvMxSsGfkW+k=; b=J9gVPZkc/ZarIAUxD9ub9k0x6BSuz/Ff0M/DaWVqpnoP9Hw6NbN443uBDlJ410Fxb0 AxYzzDwPxM0ZerZi2C4mLDZ/EnsVm8saFjZ4YSpmK2XJgVfbNuu7b0I3c8q9osTztviV hZJaA7uXB13DGgf1yo0HDHL2wHm7i95AA104moiCAhg6VFcg/sJzE/OVNFROkaNgTNZb xyzC93M8L7BjPrW+OsRFRYvwRx+jPRP17Niea0uzzVGI1tTK2un6fx4U0UJY/SFSBHN5 9bXNQHspIrp4sV4pfEVF9g2oBxU7f/nZ/CKoAz4gKvRY4SQelTyk4UvLa/arSMU/1Lov KsSQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="D3/aQyfp"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v13si8295755ejb.671.2021.05.08.07.42.14; Sat, 08 May 2021 07:42:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="D3/aQyfp"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229605AbhEHOjs (ORCPT + 99 others); Sat, 8 May 2021 10:39:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33332 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229500AbhEHOjq (ORCPT ); Sat, 8 May 2021 10:39:46 -0400 Received: from mail-il1-x12c.google.com (mail-il1-x12c.google.com [IPv6:2607:f8b0:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 23FCAC061574; Sat, 8 May 2021 07:38:44 -0700 (PDT) Received: by mail-il1-x12c.google.com with SMTP id l19so10201653ilk.13; Sat, 08 May 2021 07:38:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MZYaBypPGzWypcDz+RJ/92Ib8rkc/cBWvMxSsGfkW+k=; b=D3/aQyfp8t7ogWUaX4DRE6YvqooLIvoM/ckyPIoqkrZHNXcM2EqOXu1QAHjTG7fVIf kmhqXdpkUYYyz9TuB6QdQj2kfPmeLEVp1f/8X0S5OIYcuy03pTC6MP2haGf6MztfCB8R TfjhBHaC69s0fEsdoImJki0XbAaFl7XYDkm6JrlIMD5JwU8scWrfnZ1X5SeoQzzhK7+I CliwvA2Dwtxo9fpzoYIMeOr2O1ZQrIXE7Ktw6lJ7iP252PKUH3NtokoJ6xAyNfQN0RKU a4+rj1F2+dax6kIn+QjT59BuDO/UN3QajHe1w1DkCsQ2o64fKqSHMhJwin7YdOlCrTu/ cu3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MZYaBypPGzWypcDz+RJ/92Ib8rkc/cBWvMxSsGfkW+k=; b=NuEvFvpBOQBOfp5en2z/tpr9JkwQFuFKrpW1UCu1tpMhDLmOVMGtsmaRmesLHA/pxz Mn4YHYpsSYyYmWsxBX8rJ8JyXkE4gu9ZxXddZjdeRuYZk/smZQ/qNcNMJsXG3Pl1O6Ag cDnlCorp5FQz2qTFA4aylutMr4M2+6ixMdPsOF5kvrT1XjIQv6UrurHWLGHq9fYtFxvn mM4DpZH/5H3fXM8mZxXOzLDQ3t70aN4KKgBFcaFY2clMIeRkdQEKa0fdzAZA18Zn/1nS LTgTJ2IEcwMLF2p1rbInvBvwA3OQmdThas/d9v57Ud4JVN5+4vroS8SYAxPTEaKvN3Ow V1gA== X-Gm-Message-State: AOAM533dVu9IvLCEnFnxRXAS8JNcFghSeg6NLyhAt5CjxRWKl5tT7Ze0 tpKr2Q9We2wClevwPuY4bc/Z3rFZxAenIS2KVZj480w9oezOJQ== X-Received: by 2002:a05:6e02:20ce:: with SMTP id 14mr14078108ilq.102.1620484723400; Sat, 08 May 2021 07:38:43 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Edmundo Carmona Antoranz Date: Sat, 8 May 2021 08:38:32 -0600 Message-ID: Subject: Re: [PATCH] rtc: max77686: Remove some dead code To: Christophe JAILLET Cc: cw00.choi@samsung.com, krzysztof.kozlowski@canonical.com, b.zolnierkie@samsung.com, a.zummo@towertech.it, alexandre.belloni@bootlin.com, linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 7, 2021 at 11:43 PM Christophe JAILLET wrote: > if (IS_ERR(info->rtc_dev)) { > ret = PTR_ERR(info->rtc_dev); > dev_err(&pdev->dev, "Failed to register RTC device: %d\n", ret); Following the recent conversations, I think it might make sense to do dev_err(&pdev->dev, "Failed to register RTC device: %pe\n", info->rtc_dev); Is that right?