Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp1211126pxj;
        Sat, 8 May 2021 10:41:33 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJx9aUmJ5+H7GueyufZlFDW7rBxBYtRQMFgCiWqLeDeC4WGW6La0AQfARJ0FWObG1o2IyQgE
X-Received: by 2002:a92:c74c:: with SMTP id y12mr14658362ilp.107.1620495692911;
        Sat, 08 May 2021 10:41:32 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1620495692; cv=none;
        d=google.com; s=arc-20160816;
        b=l1StlDl1s9XXW+sW2nCcxkJwWxvou/Atv0Hb9E8KaEIctxE0RrrxvLugzpQpthCm0D
         2KGnAINZA1l5soUgCKKGOKeTfeWhbc+o9Ot6bfXreFaDc3iW0bD+aSk+ftbE36h87y5Z
         Oqc9tLRtkDcPCPEirWLsr5zenC6ZleVr/vh+qQ6dmPhNbzfUx+PmUQ58GfvcBio5skTN
         M7Lr+Z0Dcyoi5l0v9Sb5RkoFRR3W0FPpueSx7TzLtA479l+ul/TF/KP1mNARNZ2jHfMA
         mVoDQym+ffaS4mJWr3ev1TfiVWHVALsNcS0FwGi1ExdkZGL2+2a43hdmK7b/ILwLfglq
         4YOQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:in-reply-to:content-disposition:mime-version
         :references:message-id:subject:cc:to:from:date;
        bh=UGMQmQp8EZ2Ta4Dk7sD2PeHu1doTiIDtmIKhaJlzgzs=;
        b=c9Q64vY2ia2/KUgHcPFbk5sbB20V9sKEr+tMkPlT3eZOqCukpWU090s+pfoZUTW9AL
         5Ep8WQCOMhpx0H8YOU8dQfCSOGdk2e62YguEwligw774sYHQE83PpFXeyrqhM2WYv1Ls
         4ddIPscsuaXFIInje0yq2eoWUjbhOXynbn539o89nvgNb81hMPy4ksQySW0lYluHJEix
         PuGOhSVhyixRVHPJkYUHWVwmBMJx0MJI5CbCYoA0RN2Y5zeWUgsvRcnPqpnXZjwGoh4i
         nxOTflXTQ32zuz5p+kriP5e5dZ3vg8O1irv7qZQkFJgk7SBwHZRn7qDOjDoT6MEhAgDs
         eNsw==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id j6si10633427ilu.44.2021.05.08.10.41.20;
        Sat, 08 May 2021 10:41:32 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S229602AbhEHRlr (ORCPT <rfc822;lkml.email@gmail.com> + 99 others);
        Sat, 8 May 2021 13:41:47 -0400
Received: from vps0.lunn.ch ([185.16.172.187]:59474 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S229523AbhEHRlq (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 8 May 2021 13:41:46 -0400
Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2)
        (envelope-from <andrew@lunn.ch>)
        id 1lfQwS-003Hvz-TV; Sat, 08 May 2021 19:40:40 +0200
Date:   Sat, 8 May 2021 19:40:40 +0200
From:   Andrew Lunn <andrew@lunn.ch>
To:     Ansuel Smith <ansuelsmth@gmail.com>
Cc:     Florian Fainelli <f.fainelli@gmail.com>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Vladimir Oltean <olteanv@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Russell King <linux@armlinux.org.uk>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH net-next v4 07/28] net: dsa: qca8k: handle
 qca8k_set_page errors
Message-ID: <YJbNGNHNk1PxieDS@lunn.ch>
References: <20210508002920.19945-1-ansuelsmth@gmail.com>
 <20210508002920.19945-7-ansuelsmth@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210508002920.19945-7-ansuelsmth@gmail.com>
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, May 08, 2021 at 02:28:57AM +0200, Ansuel Smith wrote:
> With a remote possibility, the set_page function can fail. Since this is
> a critical part of the write/read qca8k regs, propagate the error and
> terminate any read/write operation.
> 
> Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew