Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp1215003pxj; Sat, 8 May 2021 10:48:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwcm89Q5kZf0UZCY6eZsVKJ/hx5iczPdGAFnk5/ICjGqQ2GFjDl/4TxCe1pGDTOOpP/FPFh X-Received: by 2002:a17:906:608a:: with SMTP id t10mr16928639ejj.374.1620496119667; Sat, 08 May 2021 10:48:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620496119; cv=none; d=google.com; s=arc-20160816; b=HInW+RURJkJlzLuZ7kof486raZvg+1WWy9z/PLV4fCtUH8jDSSa2wWxO3/afyScIQC VYCD/2oUBflBcV65cOWZZYQ8GlnqK/mey2yUt3lcBBOtBlgpscjzkC3loh4RJ0hShxeO d/94yt5QoYP1vxVGRWANqrCJ9kILsoCb/p/a5BrfkCmkTZMxgA3relGpZ7wQsDAFEQ98 C28QDhUTJKWENvTJTcjJ+xEix8uWo8UNtcsX+G3uRz1j/aRgsqr3glhFqJmd4am2StHC jr5ZgzoRKodiCawrGYD84F7btVS1dr+THUHAstjpTkofBE9m4abHky38BXP9+0ut21Ag RIyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=8Fm38Phs4QIsQUkbk9dUzcnDA0PJKS9qAOkuUhXdI1E=; b=GL++fqH+z82lPTJZU4YpL+B/dwfK3tKrab2359Jcg1Azr/wQdZYkQnf9Ft+wcneuw/ QFULBgVYpEn7qmDNaVJZw/ijkAZLhyxqcDnRG0Q+RgoShLLpvn8xYDx9VZnunL9uqZJg xqUg0Avz5L1jplx7CUvv3PYZKx6fvFQ2Vn8wX2pJEOL3wnhKG41nBk0XgD1pj6lQBTsB JcsOks9lTPN2qvVTku1i1Iq4v3EZ9mVQfbE3S3xWKGdHIWSE3DU/ZJr6d/4pFs/of8oZ WsKLgnZ6eazPR8Qu1YCsaPE5H/yH1GEvN66iKfs7G3VrUK5+DUQMqBzn27eCHnSJoSPd hSXg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g19si8635916eds.491.2021.05.08.10.48.16; Sat, 08 May 2021 10:48:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229738AbhEHRs3 (ORCPT + 99 others); Sat, 8 May 2021 13:48:29 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:59498 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229560AbhEHRsZ (ORCPT ); Sat, 8 May 2021 13:48:25 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1lfR2u-003Hyr-Hc; Sat, 08 May 2021 19:47:20 +0200 Date: Sat, 8 May 2021 19:47:20 +0200 From: Andrew Lunn To: Ansuel Smith Cc: Florian Fainelli , Vivien Didelot , Vladimir Oltean , "David S. Miller" , Jakub Kicinski , Russell King , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH net-next v4 09/28] net: dsa: qca8k: handle error with qca8k_write operation Message-ID: References: <20210508002920.19945-1-ansuelsmth@gmail.com> <20210508002920.19945-9-ansuelsmth@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210508002920.19945-9-ansuelsmth@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 08, 2021 at 02:28:59AM +0200, Ansuel Smith wrote: > qca8k_write can fail. Rework any user to handle error values and > correctly return. > > Signed-off-by: Ansuel Smith Reviewed-by: Andrew Lunn Andrew