Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp1265226pxj; Sat, 8 May 2021 12:16:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyprzM+NuyP3xX+OCig21cuYVGr/dos1LIdCTPvj082gy7Vw3a+Do4pzwQGXnGn+8Kv1K47 X-Received: by 2002:a05:6602:242b:: with SMTP id g11mr12043255iob.105.1620501359979; Sat, 08 May 2021 12:15:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620501359; cv=none; d=google.com; s=arc-20160816; b=NaYMpsGzAIIHCQNR/usXGpavaRFz8QiSgsx6mVcFkdAP4rub4tYvv7774Hy04Wm6MA F5FVIrOivKd6VQK83BSB5kZ6nDg4q3yohysPVilDy9gRGxc52G2IVz+Af6cYCO+hw/KE Duid8pzjNfYZlIh/jICOeoZRZ8xZpBVmkt6vPtKp26N7QCL9tWGKjahr3AxemN/ZftPD PGjrzJLKLBEK6f9PFzMk9Hcv4JDjgeK+d5igaxEqZZ7zR4PSrZz28estHgrPvu2rKiiS KHkGKLB6S6s7Rv+yuCMvltYX7dGs26HqFvlY3XMKWqCk3PBbah60zcePvFTt5Ixen3pq meNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=0Av5qgnuXyZ/0iZ16+DzsrzBiOxG3RbEqxFfb99lsx0=; b=wAMHooFFSj8NvjYkIHgRzbp/a9JPAcMv94AGueGT1y7rP6NlLn9etIVgAEaLudlzi5 znZib8pwscOkMB9/yyWxis0riYW+aYc6xgIKAP0Xsv3x8lQwWcVJX86oXVd7T/Y2jmyv AhqOBJoLHklKfK9OCKFFaVX6XPhVg76+hNGw00H5BvjOlE6+IuldThBQXnPhu/IvtueS whuqD+sWOif+Fj/YbDiZKl/g07yiqZmFOYK0jcfl+AgsVw1hIFI+NypV519+mk/k6bfQ XjNiE2+194dgJ+6mTCUU/0m1CetFZ9H6g6lfOGXVQ4AoWUzoF6xDrcycVxNrhedlQL9C 4eQw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v6si9361443jas.16.2021.05.08.12.15.46; Sat, 08 May 2021 12:15:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229649AbhEHTO7 (ORCPT + 99 others); Sat, 8 May 2021 15:14:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36748 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229489AbhEHTO6 (ORCPT ); Sat, 8 May 2021 15:14:58 -0400 Received: from zeniv-ca.linux.org.uk (zeniv-ca.linux.org.uk [IPv6:2607:5300:60:148a::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F07E5C061574; Sat, 8 May 2021 12:13:56 -0700 (PDT) Received: from viro by zeniv-ca.linux.org.uk with local (Exim 4.94 #2 (Red Hat Linux)) id 1lfSNq-00Cjjx-9s; Sat, 08 May 2021 19:13:02 +0000 Date: Sat, 8 May 2021 19:13:02 +0000 From: Al Viro To: Linus Torvalds Cc: Jia He , Petr Mladek , Steven Rostedt , Sergey Senozhatsky , Andy Shevchenko , Rasmus Villemoes , Jonathan Corbet , Al Viro , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , "Eric W . Biederman" , "Darrick J. Wong" , "Peter Zijlstra (Intel)" , Ira Weiny , Eric Biggers , "Ahmed S. Darwish" , "open list:DOCUMENTATION" , Linux Kernel Mailing List , linux-s390 , linux-fsdevel Subject: Re: [PATCH RFC 1/3] fs: introduce helper d_path_fast() Message-ID: References: <20210508122530.1971-1-justin.he@arm.com> <20210508122530.1971-2-justin.he@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Al Viro Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 08, 2021 at 08:30:43AM -0700, Linus Torvalds wrote: > In fact, I think it would clean up prepend_path() and make it more > legible to have the two layers of mount_lock / rename_lock be done in > callers with the restarting being done as a loop in the caller rather > than as "goto restart_*". Potentiallty delicate question is how to pass bptr/blen to the caller of that helper...