Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp1410746pxj; Sat, 8 May 2021 17:07:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxwk1QUUaVUxVvpnc5iyNicF6bwO7B2u4KcZ2tnik72dXdcolB9qaNu7H3UMpKOBiqomW+3 X-Received: by 2002:aa7:c390:: with SMTP id k16mr17085120edq.97.1620518858397; Sat, 08 May 2021 17:07:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620518858; cv=none; d=google.com; s=arc-20160816; b=s9rK8BT2X2SQVI2IEzrIWOW2//FZJoFW2A1nWA0qbJkeUOEpQ4cGgOFDNvQJPiMYTn s5mEsx4MJnSDy/TcBL5cwhehh1Nqg+1dVFppDH9uPPfnrHzdHvIQzhdVZpyiy/mwaVOS fFjG8/5l2JAlcJRuYa2ckIPygTKmK8YvllJe1QQQm6IbEuuI/452VHTzsXQNQesyfl4O nwItCayuhYas8XkdO2AKfGuQkE6dI4VjleJD44vPWdYvPKpT12qLkGPsI3SMIF+uPH48 0xgC5jw1JyH5XE263yY343j6KZnE0ls51bUFNxuqfdj1DPOX9h4hsHwWDhYy/IuXNatO +TWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=3nk5otuuvpQdd5V63KbzQrvfCEVv6aZKunZOJD4xz+Q=; b=UwgiAulBfOELS2KlUdeW45ju7PwfDQE+wls66A6UwGdUXSlyYsuaxC9ZNdwrTv7Dzb IEXTzEgFy73/E8y+MuotuTEAKHEqPtvDn6QU1MT7EXA5XxqRdTKTscPzM+Xb8L9/eX6U Dbfliz4u480f1KOrB7WTsOcNFf/aFhRBwSgm2MG+kykg3ZJVmpFAzupX+/itiXtjsS3k ovLYn7+kh2nBh+8Na6Jnkkzd0Dlt4f8AUE3O+gwR4NwS72j+N/DR3lgXOKZwYhTseSWr UiUssduuvZ0RS1DcFUh62JAG9ZKOo8EyyJ3zZP2zf4QkfnDKBBBMqf8urJ1mCUvEecBL qd8w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=EVD6P7md; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id hq17si6070522ejc.641.2021.05.08.17.07.14; Sat, 08 May 2021 17:07:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=EVD6P7md; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229664AbhEIAHT (ORCPT + 99 others); Sat, 8 May 2021 20:07:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43150 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229570AbhEIAHS (ORCPT ); Sat, 8 May 2021 20:07:18 -0400 Received: from mail-il1-x12d.google.com (mail-il1-x12d.google.com [IPv6:2607:f8b0:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 58E1DC061573; Sat, 8 May 2021 17:06:15 -0700 (PDT) Received: by mail-il1-x12d.google.com with SMTP id v13so10967268ilj.8; Sat, 08 May 2021 17:06:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3nk5otuuvpQdd5V63KbzQrvfCEVv6aZKunZOJD4xz+Q=; b=EVD6P7md3BCemopGoXFblj0Li3O8zld2a65mjbKBWDCLt3m5dn1hDXUJ9o7Jhj6Add WOpj9+ppOm2mZtzubG/2UYiFyDwsjpTJn+tw7GqNuGUmfRndU448KnS9ep9qcQEy3hiI wmACAKWfkiyKxh/Vy/USXsEz6Xn/1xIXyYjwRa3fiBUrFnMb1UobFN5K3QAA3icOAGGo B0Lu7Ueg1FM4B13BWYU/YyugfX2qJ3DERqOkl85GdLCT+t0EkJUiTjHSs/FOyzhyVM5M p5HDkdoz8/3fnffNCWhXXye0gxSDoqJ8P7axFAZwVFpxO5l6qs89wrwS3CxAMQQ/GCAe rIbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3nk5otuuvpQdd5V63KbzQrvfCEVv6aZKunZOJD4xz+Q=; b=T1AFyFjg93wQcIkaWl5I1hrzn1z/DPN4SaslBRmyoYsQ27I+D++kdt8btamHDCwwhq 5PKmrMI29DB7O4NAbxUzGgD3IDmBNuu09+t4o9TUpwqN8rwC5yTNn4Z3Hgmu2UDhK7Kq UmqRrYmyYSceEy3E+DW0zdvb0P2MSGJZ+jkvg7JKgiKEuBxuBd738AjrcJvlIHNwtqyE 0BcGXucZSCUJ+PpSoIjjUVjdJSko3tM3bwUnViEG1vCRqY3o0KuNdRlX99vkLCBsZpLJ wTHo8i1ubKTNFBaeUuOMTMOEsHW716wuZD/7gtd3NInaCCubBTZS2r6RV+/AEjMUFXXi u1oQ== X-Gm-Message-State: AOAM5337jydBXNb17QvOetlgsn893VXKLWDo87g+ilUlEVVr6vvYJ5gu NuGfgiTA5Ewxotriwv/vyLJ2aHtzI0XES3fq0vg= X-Received: by 2002:a05:6e02:20ce:: with SMTP id 14mr15581662ilq.102.1620518774641; Sat, 08 May 2021 17:06:14 -0700 (PDT) MIME-Version: 1.0 References: <9f34ebcd-0c17-cd7f-eb08-52c6c3dc7b03@wanadoo.fr> In-Reply-To: <9f34ebcd-0c17-cd7f-eb08-52c6c3dc7b03@wanadoo.fr> From: Edmundo Carmona Antoranz Date: Sat, 8 May 2021 18:06:03 -0600 Message-ID: Subject: Re: [PATCH] rtc: max77686: Remove some dead code To: Christophe JAILLET Cc: cw00.choi@samsung.com, krzysztof.kozlowski@canonical.com, b.zolnierkie@samsung.com, a.zummo@towertech.it, alexandre.belloni@bootlin.com, linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 8, 2021 at 10:59 AM Christophe JAILLET wrote: > > > > > Following the recent conversations, I think it might make sense to do > > dev_err(&pdev->dev, "Failed to register RTC device: %pe\n", info->rtc_dev); > > > > Is that right? > > > > Yes, it is right, but it should be done in another patch. > > Would you like to give it a try? > Sure, I'll have the patch ready to send it when I see yours on next. > CJ