Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sat, 8 May 2021 17:52:50 -0700
From:   Andrew Morton <akpm@linux-foundation.org>
To:     Alexander Potapenko <glider@google.com>
Cc:     pmladek@suse.com, mingo@kernel.org, bo.he@intel.com,
        yanmin_zhang@linux.intel.com, psodagud@quicinc.com,
        dvyukov@google.com, elver@google.com, linux-kernel@vger.kernel.org,
        ryabinin.a.a@gmail.com, he@google.com
Subject: Re: [PATCH v2 1/2] printk: introduce dump_stack_lvl()
Message-Id: <20210508175250.d28548e312bfae4c8d779e2d@linux-foundation.org>
In-Reply-To: <20210506105405.3535023-1-glider@google.com>
References: <20210506105405.3535023-1-glider@google.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Thu,  6 May 2021 12:54:04 +0200 Alexander Potapenko <glider@google.com> wrote:

> dump_stack() is used for many different cases, which may require a log
> level consistent with other kernel messages surrounding the dump_stack()
> call.
> Without that, certain systems that are configured to ignore the default
> level messages will miss stack traces in critical error reports.
> 
> This patch introduces dump_stack_lvl() that behaves similarly to
> dump_stack(), but accepts a custom log level.
> The old dump_stack() becomes equal to dump_stack_lvl(KERN_DEFAULT).
> 
> A somewhat similar patch has been proposed in 2012:
> https://lore.kernel.org/lkml/1332493269.2359.9.camel@hebo/
> , but wasn't merged.

Um yeah, I dropped the ball on that one, didn't I?  I suspect pretty
much all dump_stack() callsites should be using this.