Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2021492pxj; Sun, 9 May 2021 12:27:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyu0Je7o4WjGevgp71F08TueoLBUmvKYZCNvCTicyh4dTdK7qd1CfC/eGsDN5T6SQpzt3LR X-Received: by 2002:aa7:c15a:: with SMTP id r26mr25844014edp.78.1620588474590; Sun, 09 May 2021 12:27:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620588474; cv=none; d=google.com; s=arc-20160816; b=X4tHZFEJ6mAfm6Hv3LuwyOvRTeEwe7K1w9HY/up36l8piOiIbJNdm0PRCEeJF5tRNT r7ElYKrFYrcBWCMvqzIV62fJbVb7AbYyqgBMpuhaOaFvU4Ine3NYE1QJnExgZ2fF4mqA AFaDqA7a/FVGz9IEDvY3FD27NCd9eL0Chs61HrlWRLTQQRl84OdblF4/6yh7cPirkIe0 nSrFRh2MeZcyaL3zoej4HBGI9iUwfaVWP0L/QV4Riw/ANKnpCJSIiau0VEX6svPwKRCE W04E/SCl9EOeE8aA2xB/MICmI+jBQyBdAAuwraaUgr1/5YMyvq8IMQGsKODIreXK7HwG EJMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=r2dEu4hvQezgg+nEKJ+VJ/vBdC0xX4twJSBrlDmPz9g=; b=tJh+VQJKIzK6czXuVcZU6Sk5w914pFrtXbAh0rvK7rvGZ0Ot5Zpj6ysCkQbYgKAkVr D+jqugWPzSN4sc9oxyuxz8pFDJ7fjZBEfwoPKhWdr5dBpbkBZ09cFpjcMxsFPOqeBsYg +uKLVIqkBY7UfruIOPA95QTy8FCl6El5sK6sijfEydiqf5vDWbIwuUHIvWkU5xXPm+QZ ldSzJw5Y7pYgyZ1eoaKZDe6MCHKud092AFxyZVlB9D2tgaD+kNg9qVj8vWmy9Ps67DsD ZP/Eqb3xMWVi3+rpTCAjdEO8eSnN7th3OMDWtcOdCBoMLdSAYHwE4S3etTXS09FPo8TS AQVg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="G/KL0GMi"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h8si11669834ejj.270.2021.05.09.12.27.28; Sun, 09 May 2021 12:27:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="G/KL0GMi"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229852AbhEIT1j (ORCPT + 99 others); Sun, 9 May 2021 15:27:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37826 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229666AbhEIT1j (ORCPT ); Sun, 9 May 2021 15:27:39 -0400 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C6D0AC061573; Sun, 9 May 2021 12:26:35 -0700 (PDT) Received: by mail-wm1-x32a.google.com with SMTP id l24-20020a7bc4580000b029014ac3b80020so9948206wmi.1; Sun, 09 May 2021 12:26:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=r2dEu4hvQezgg+nEKJ+VJ/vBdC0xX4twJSBrlDmPz9g=; b=G/KL0GMi8jlxQvskJcAJpLMVgkkRInd/fz5i0z+p0mE+1pAMVNLchRxBNJuFtvEGqT S0/auBsfA+rb1D9KysOl+9o26ITBn10gu4jWCgHHGf7bNY4eKrKJWa6qp5Z8V2y5JMcc aGeu02f85d2ON87lBYZAhzKaWxKKeYn8N69nhGT+UFbqKJVmC/n3fM6Sl4rG2tkPU0EB nKMlYqqcwXUBGCvAI+4G99gOG4Fxax23KM/y6hyGYYjxavfix+2b6RTDd9W040MGi4TB DoE4YQqcO/Puqq7BSRpgqAmauieoEDpH6yw8PjGTecyMIORdKKhKyhWESufyet8gbpLh Ifqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=r2dEu4hvQezgg+nEKJ+VJ/vBdC0xX4twJSBrlDmPz9g=; b=O7jkqrqlfywBDpU2Xb+aZvoq4H4mZNUJLJY+x5evXNdDh7fAAM0F2HzfT0cmCh3oHl jGFw8bfc7ZXbTDfpWL7iDLCt9RlEZ4tNSjiXP4d/U+FqHeOLyKzSZpbXVd0uAUUCiXZv VUgmC2ZQV9t1Ix8atclPJah3Ojkr5stTQcot7HycKvDbM04QAbQaG+SWDvRsQ+5BuSwQ kJp6MjHx/LQMVIJpUsUKqbBz2vxVHE6ZVOIww3wj6LfsdUMrAmQFSaAw5GjVKyiKrDUP qM+9B8Liuei0BhfgWRd9QJnWDaEiNg6NUbjcbOHO79pUQuVw+UZD4v1Mo7DMZgsDDjWn vsWw== X-Gm-Message-State: AOAM533gOClG0p9UJs388Ox8gb2yiv7jpAmnpmR5+LTTJpEdo4r/6sxw G/UvBwgH3QjefT/Tkpp2854= X-Received: by 2002:a1c:4c07:: with SMTP id z7mr22592916wmf.96.1620588394388; Sun, 09 May 2021 12:26:34 -0700 (PDT) Received: from skbuf ([86.127.41.210]) by smtp.gmail.com with ESMTPSA id d15sm19175233wrw.71.2021.05.09.12.26.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 09 May 2021 12:26:33 -0700 (PDT) Date: Sun, 9 May 2021 22:26:32 +0300 From: Vladimir Oltean To: Christophe JAILLET Cc: broonie@kernel.org, maitysanchayan@gmail.com, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] spi: spi-fsl-dspi: Fix a resource leak in an error handling path Message-ID: <20210509192632.2nzgwckpai34hgnr@skbuf> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, May 09, 2021 at 09:12:27PM +0200, Christophe JAILLET wrote: > 'dspi_request_dma()' should be undone by a 'dspi_release_dma()' call in the > error handling path of the probe function, as already done in the remove > function > > Fixes: 90ba37033cb9 ("spi: spi-fsl-dspi: Add DMA support for Vybrid") > Signed-off-by: Christophe JAILLET > --- Reviewed-by: Vladimir Oltean Thanks!