Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2066230pxj; Sun, 9 May 2021 14:10:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzQXl3m6FiK331OrinOVjNJVZOpnxYErv0VQNHnhJhcmjX7TCCfjMeR0gQk7z5Ol7WvKNNB X-Received: by 2002:a17:906:a51:: with SMTP id x17mr22413793ejf.25.1620594626819; Sun, 09 May 2021 14:10:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620594626; cv=none; d=google.com; s=arc-20160816; b=rCXDyRAugTeIaX53doORIQ0NQBVmV4MFhuBtJqyRXCb6leadPHDHzWOpnoA28H2ZnL lw2nFQrGJmzYdUyujazLeVdwyGTN4D+5e5yrFuq0023nJyv1YPHkQ3R/Z10LGv7yw3gS M8aj4pLdhm0a4i6yK+d7ShfiipoTN8S4DuBN9qTAMHwdsbcXdHg35Z51jdVyI1pBa6bJ QgO9FK4za/DqniN3hWpef0lpIPxm+CKoXkzeVEBUVWuHgUUHzXBQnhBl5CFZ2GLJN+1K aWPEMzS4RVtPFs0oDMFQipA5BScckIi+um6IFnOVJgd2MA/Deii3b7zg9BZCvCzoEYfE gHtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=Rj7RXwO20SpuxABKVjvl64XUs+Bll34M8hFfQumGshU=; b=iMlp9HXFIhmpEZYgvpkC9ynkIyeRssCp54m7AwX/DvEB7FF5NO/aMu/U8Y5ufTnwVa yFALv2zZzWFXjI9wskjNJEoSlAh+uwCumOPT3Bol1ZPwDYE2Ck30KoxgXUvYf0qF+r8X MN9Odljhskllv8lBR+gT3WCJid9dnHiIe4d37TuuWrszdsMxM2LTQk3y7+CndxhWEtRr ioWkn9zNe0GFD2B608EfsGpgNcNVVPDnhi14B1/kx+Z+pIcvDzO5sf+hbIU5fxEvxuyH Mgu8pgRqRK/SpiVkBTlFBqMlQWCJQvoiZZIUx9EWvNCPNHrbvBAZ1DICHb6JD666/v4h m89w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z15si11481251edx.253.2021.05.09.14.09.50; Sun, 09 May 2021 14:10:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229924AbhEIVHc (ORCPT + 99 others); Sun, 9 May 2021 17:07:32 -0400 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:55437 "EHLO relay8-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229840AbhEIVHb (ORCPT ); Sun, 9 May 2021 17:07:31 -0400 X-Originating-IP: 90.65.108.55 Received: from localhost (lfbn-lyo-1-1676-55.w90-65.abo.wanadoo.fr [90.65.108.55]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 1863D1BF207; Sun, 9 May 2021 21:06:26 +0000 (UTC) Date: Sun, 9 May 2021 23:06:25 +0200 From: Alexandre Belloni To: Edmundo Carmona Antoranz Cc: Christophe JAILLET , cw00.choi@samsung.com, krzysztof.kozlowski@canonical.com, b.zolnierkie@samsung.com, a.zummo@towertech.it, linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] rtc: max77686: Remove some dead code Message-ID: References: <9f34ebcd-0c17-cd7f-eb08-52c6c3dc7b03@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/05/2021 18:06:03-0600, Edmundo Carmona Antoranz wrote: > On Sat, May 8, 2021 at 10:59 AM Christophe JAILLET > wrote: > > > > > > > > Following the recent conversations, I think it might make sense to do > > > dev_err(&pdev->dev, "Failed to register RTC device: %pe\n", info->rtc_dev); > > > > > > Is that right? > > > > > > > Yes, it is right, but it should be done in another patch. > > > > Would you like to give it a try? > > > Sure, I'll have the patch ready to send it when I see yours on next. Does it make sense to print anything at all? Who would use the output? Is anyone actually going to read it? -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com