Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <CAPM=9twAN82gkzrfc2CGQopjkjEdWtBKMF2DgBOtw+6RsZ++fw@mail.gmail.com>
 <CAHk-=wgf+kHeSZbpkZumWcTXUD7ordqTMvPRNL6aQVG1DSBDnQ@mail.gmail.com>
In-Reply-To: <CAHk-=wgf+kHeSZbpkZumWcTXUD7ordqTMvPRNL6aQVG1DSBDnQ@mail.gmail.com>
From:   Dave Airlie <airlied@gmail.com>
Date:   Mon, 10 May 2021 09:28:08 +1000
Message-ID: <CAPM=9tyji5UqZu4hV3gGNKpm5aTgau7oED9wMWqK8bjVvon_NQ@mail.gmail.com>
Subject: Re: [git pull] drm fixes round two for 5.13-rc1
To:     Linus Torvalds <torvalds@linux-foundation.org>
Cc:     Guenter Roeck <linux@roeck-us.net>,
        Daniel Vetter <daniel.vetter@ffwll.ch>,
        dri-devel <dri-devel@lists.freedesktop.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, 10 May 2021 at 07:08, Linus Torvalds
<torvalds@linux-foundation.org> wrote:
>
> On Sun, May 9, 2021 at 11:16 AM Dave Airlie <airlied@gmail.com> wrote:
> >
> > Bit later than usual, I queued them all up on Friday then promptly
> > forgot to write the pull request email. This is mainly amdgpu fixes,
> > with some radeon/msm/fbdev and one i915 gvt fix thrown in.
>
> Hmm. Gcc seems ok with this, but clang complains:
>
>    drivers/video/fbdev/core/fbmem.c:736:21: warning: attribute
> declaration must precede definition [-Wignored-attributes]
>    static const struct __maybe_unused seq_operations proc_fb_seq_ops = {
>                        ^
>
> but I noticed it only after I had already pushed out the pull.
>
> I'm actually surprised that gcc accepted that horrid mess: putting
> "__maybe_unused" between the "struct" and the struct name is very very
> wrong.
>
> I fixed it up after the merge due to not noticing earlier..
>
> Maybe the drm test robots should start testing with clang too?

My current build, test + sign machine " 09:23:22 up 419 days", running
fc29, has clang 7 which is my current blocker on implementing a clang
bit in my build cycles.

The machine is in an office, that due to RH not being able to fathom a
country where COVID isn't rampant, I have to fill insane amounts of
paperwork and high management intervention to visit, I'm afraid to
remote upgrade or reboot it unless I really have to.

I've some rough ideas to update it to f33/34 which would give me a
good enough clang, I suppose I could just build my own llvm/clang I've
done so for years for other reasons, if I can't come up with an update
plan soon I might consider it.

Dave.