Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2190228pxj; Sun, 9 May 2021 18:39:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw8jFVx6gR2nf40jCXJwbbe5rgWQE2Bzh4600Vf8zOYhmmN4dresiiibs5cebLSpy8m6YNx X-Received: by 2002:a5d:9682:: with SMTP id m2mr16529570ion.20.1620610742334; Sun, 09 May 2021 18:39:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620610742; cv=none; d=google.com; s=arc-20160816; b=CAe68DRlqdmvLt06ubCX6Vl94VDU/vGBGnA9yAfIwCJROgdqAi4O3U5vtRRqYgEVwy xs1u6Y+tifYf1tVSooJmZ+YJUwaSF0OMlQuyaI9/HgJKoDOIVuf6TO9gSx9qXaP3j6Hh +/Lq3yiLRrhGpA90CAEI+HCo5Cf/d8CZZv3aJltVR9OGwY2tl2N3g+7z3AAXxpWqFeZi VGDLxa1bjDdNPbg7WE7BRD1MjmZ41FZZhz8X5QkIibcXWYlZWXJs/DSkxUKLtJ/N+vHn +zPscdrUYOsDDxiFeQt/vrPKqiBymhtkfs4kfy0n8zNyOJUdrRA0ZzoxrqItUmRIPGm9 ZCpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=d3HKIpSf0w3jmpAYe3bKaHuy0GEVYEjSwnRh5GHvicI=; b=EfzBWJF5oFkTxQ+/XN77DkgeWZv45utzfpJL8s5ySHZCcpm8w8u7XiEGiVQs8khZSc dMIybFMnG2p1XuVDx4EEIM+TBWz+8i4yq/8qv0FrHExFMcLdJMB8rGNIOAKVl7WfH4JB x4k5/yLqmqDQf0Qsr3dsy+Pl0KKgG/44DqBKRhk47UX3pADIGBBWHIWUjDL0OTI6/uyA +GtXiwYkbgM1U0A8miio5tqmdHNy43sh1YDT1N7dTddIbaoX8CQslNVrA+0COBmfIB/0 SJDSpWRhVkbSEnKTSPZucOB775og4xTG0XlS1GINjkQWjaL1ARDm3qw/TXpqXcpF1P0o y04g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=vivo.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z10si14400079ilp.153.2021.05.09.18.38.49; Sun, 09 May 2021 18:39:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=vivo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230150AbhEJBg2 (ORCPT + 99 others); Sun, 9 May 2021 21:36:28 -0400 Received: from mail-m17670.qiye.163.com ([59.111.176.70]:30480 "EHLO mail-m17670.qiye.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230034AbhEJBg2 (ORCPT ); Sun, 9 May 2021 21:36:28 -0400 X-Greylist: delayed 534 seconds by postgrey-1.27 at vger.kernel.org; Sun, 09 May 2021 21:36:27 EDT Received: from ubuntu.localdomain (unknown [36.152.145.182]) by mail-m17670.qiye.163.com (Hmail) with ESMTPA id 3DEAD3C00AC; Mon, 10 May 2021 09:26:28 +0800 (CST) From: zhouchuangao To: Jens Axboe , Oleg Nesterov , "Eric W. Biederman" , "Peter Zijlstra (Intel)" , Thomas Gleixner , Peter Collingbourne , Marco Elver , linux-kernel@vger.kernel.org Cc: zhouchuangao Subject: [PATCH] kernel/signal: Modify the comment of function check_kill_permission Date: Sun, 9 May 2021 18:26:20 -0700 Message-Id: <1620609982-25340-1-git-send-email-zhouchuangao@vivo.com> X-Mailer: git-send-email 2.7.4 X-HM-Spam-Status: e1kfGhgUHx5ZQUtXWQgYFAkeWUFZS1VLWVdZKFlBSE83V1ktWUFJV1kPCR oVCBIfWUFZQx5DTVZCSR8fQxlMGB1OHkJVEwETFhoSFyQUDg9ZV1kWGg8SFR0UWUFZT0tIVUpKS0 hKQ1VLWQY+ X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6PTI6Ajo4Tz8UMz9WFBQxSj01 NTQwC05VSlVKTUlLTUtCQkNDQktLVTMWGhIXVQETFA4YEw4aFRwaFDsNEg0UVRgUFkVZV1kSC1lB WUhNVUpOSVVKT05VSkNJWVdZCAFZQUlLSEM3Bg++ X-HM-Tid: 0a7953e1f78cda5akuws3dead3c00ac Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Maybe it's easier for us to understand the function of check_kill_permission(). Signed-off-by: zhouchuangao --- kernel/signal.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/kernel/signal.c b/kernel/signal.c index 66e8864..8335f17 100644 --- a/kernel/signal.c +++ b/kernel/signal.c @@ -861,8 +861,10 @@ static bool kill_ok_by_cred(struct task_struct *t) } /* - * Bad permissions for sending the signal - * - the caller must hold the RCU read lock + * Check whether the caller has permissions to send the signal. + * - The caller must hold the RCU read lock; + * - Return 0 means permission is allowed, otherwise returns the + * corresponding error number. */ static int check_kill_permission(int sig, struct kernel_siginfo *info, struct task_struct *t) -- 2.7.4