Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751810AbWJWIOp (ORCPT ); Mon, 23 Oct 2006 04:14:45 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751804AbWJWIOp (ORCPT ); Mon, 23 Oct 2006 04:14:45 -0400 Received: from mtagate3.uk.ibm.com ([195.212.29.136]:44909 "EHLO mtagate3.uk.ibm.com") by vger.kernel.org with ESMTP id S1751810AbWJWIOo (ORCPT ); Mon, 23 Oct 2006 04:14:44 -0400 Date: Mon, 23 Oct 2006 10:14:41 +0200 From: Muli Ben-Yehuda To: "Eric W. Biederman" Cc: Andi Kleen , Yinghai Lu , Linux Kernel Mailing List , Andrew Morton Subject: Re: [PATCH 2/2] x86_64 irq: Only look at per_cpu data for online cpus. Message-ID: <20061023081441.GP4354@rhun.haifa.ibm.com> References: <200610212100.k9LL0GtC018787@hera.kernel.org> <20061022035109.GM5211@rhun.haifa.ibm.com> <20061022085216.GQ5211@rhun.haifa.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.11 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1398 Lines: 34 On Sun, Oct 22, 2006 at 10:35:34PM -0600, Eric W. Biederman wrote: > > When I generalized __assign_irq_vector I failed to pay attention > to what happens when you access a per cpu data structure for > a cpu that is not online. It is an undefined case making any > code that does it have undefined behavior as well. > > The code still needs to be able to allocate a vector across cpus > that are not online to properly handle combinations like lowest > priority interrupt delivery and cpu_hotplug. Not that we can do > that today but the infrastructure shouldn't prevent it. > > So this patch updates the places where we touch per cpu data > to only touch online cpus, it makes cpu vector allocation > an atomic operation with respect to cpu hotplug, and it updates > the cpu start code to properly initialize vector_irq so we > don't have inconsistencies. > > Signed-off-by: Eric W. Biederman I tried 1/2 and 2/2 at the same time and it booted, so good work :-) I'm stressing the machine a little now, will let you know if anything out of the ordinary comes up. Acked-by: Muli Ben-Yehuda Cheers, Muli - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/