Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751821AbWJWIlB (ORCPT ); Mon, 23 Oct 2006 04:41:01 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751828AbWJWIlB (ORCPT ); Mon, 23 Oct 2006 04:41:01 -0400 Received: from nf-out-0910.google.com ([64.233.182.189]:47128 "EHLO nf-out-0910.google.com") by vger.kernel.org with ESMTP id S1751821AbWJWIlA (ORCPT ); Mon, 23 Oct 2006 04:41:00 -0400 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:reply-to:user-agent:mime-version:to:cc:subject:references:in-reply-to:content-type:content-transfer-encoding:from; b=VY/8GzqVpH4Pn8am4ZqYcO0VhIpY+MJP/F/dxB+eDuSJj+/ODNM3Tw8fXdjzquMDrzjtPbewoO9/1lGkPe1Gmd7i0/7WXEyLXmIgOESVuYeAonM2YUwGbe/fm85mlHPBp3v/phCPv6gDn11BhKYdY+rfn5X5KZPG6XdN+fk0WKo= Message-ID: <453C8027.2000303@innova-card.com> Date: Mon, 23 Oct 2006 10:41:11 +0200 Reply-To: Franck User-Agent: Thunderbird 1.5.0.4 (X11/20060614) MIME-Version: 1.0 To: Miguel Ojeda Sandonis CC: akpm@osdl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2.6.19-rc1 full] drivers: add LCD support References: <20061013023218.31362830.maxextreme@gmail.com> <45364049.3030404@innova-card.com> In-Reply-To: <45364049.3030404@innova-card.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit From: Franck Bui-Huu Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1053 Lines: 30 Franck Bui-Huu wrote: > Hi > > Miguel Ojeda Sandonis wrote: >> Andrew, here it is the complete patch again as you requested. >> > > sorry for coming lately, I just noticed your patch in -mm tree. > > Did you took a look at drivers/video/arcfb.c driver ? > It seems to be a fb driver for ks108 lcd controller. A lot of code > is related to the platform though and the controller is driven > through GPIO but have you tried to split the code for sharing > controller specific code. Note, I don't say it's a good idea, it's > just a question that comes in mind. > > Also you create driver/auxdisplay directory whereas drivers such > the one I mentioned previously is located in drivers/video. Why > not putting your driver in driver/video ? Is this driver is already no more maintained ? Thanks, Franck - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/