Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2271216pxj; Sun, 9 May 2021 21:36:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzHhWtWsGXvlNGNXk7xVBjk1jyuuVTST1lGpb++pM+fKaXXGAtXIeQXnxGSFCTwGpL5rhYE X-Received: by 2002:a17:906:c099:: with SMTP id f25mr23333167ejz.499.1620621385159; Sun, 09 May 2021 21:36:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620621385; cv=none; d=google.com; s=arc-20160816; b=kUrOhy0OqruhTSXzb41NuZ829wQxB4Xj28Gp4shdxlcX6jk1rGCfMSn3659VZP+yoE 61qd+d9N+gTYV8ln6ZfC7Hr5k6c9psdomVJT6c5U467EDCd5N98e5ym2YmZnm2qbJNtN 1YCA/9nKQX11tnBNBHiS/MA/Am5h4D2aFy/pR2g2o2HDkDM6RzqHq4u0sL9srudKkfqw ErmnOy7YB/PtrJVEynPKUc9VFb/lT0RjaI6s7dnESkxzQbQoLMiKRjPA2CEOau9jTEs6 9PfD5hEpBFwDILRrSoMM+d+LRbHNVRZ8u3nXx2vS2S5DTLYbmQjEPDgi31fhPZwQCOAL 5UfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=28F/6aFUeuEUIf+TKbmZ6q/lfCo/Hi3ti7AsC0Tt6Jc=; b=il3iF5Bp1XobTL+K3biC032Q5+/aWixTacRhJedBvKB/MnIohiytubATW6z5DG0Z7U 2MTpYfiePiN/TVXkGI1cZcLaawKIB2M6+QvAUDKnhIYxSOwDENZ7VGaLHucMN/OeNwXf RLBQmv1Auf8nraza89mPsHNdRjj1T/XGRHNFsey0/Xb0w12e2LGqxYhjqFMxiPVFkGJL Z0kXotY0McXAOcYzZSo4sUK+AfBLWhe0y6YTTOkVNJfZuCqpOBqphuIAPbnGKu0C0rra o1FqEifHnEFayTj2QvWt9i01Kig13XuRB5yDmgI7VazdbpELLViMnC9w+91X6B2P9/On Fh4A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=pda+AWAt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u11si12058438edq.89.2021.05.09.21.36.00; Sun, 09 May 2021 21:36:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=pda+AWAt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229976AbhEJE2A (ORCPT + 99 others); Mon, 10 May 2021 00:28:00 -0400 Received: from mail.kernel.org ([198.145.29.99]:34758 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229967AbhEJE17 (ORCPT ); Mon, 10 May 2021 00:27:59 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id E07A66100C; Mon, 10 May 2021 04:26:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1620620815; bh=odosyeUkF8IMRHT7IXOdmt7HbqZ5eRV7yGJJrHVHxf8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=pda+AWAtFXjbJG05uulfL5FQb+jKO7zJKI9I3eFJJzpDSnyc0JBmDjGSma8dynEba o9ZzpAwECdcUAu/1kz1ARy7WD2l55Gm43c65pNn/ibW7npCqF7rxGWiaO5i5D2HHVD m7cawHclZSAxIELdYA04S+HPymhkSQZDFsWoHk8E= Date: Sun, 9 May 2021 21:26:54 -0700 From: Andrew Morton To: Liu Shixin Cc: Anshuman Khandual , , Subject: Re: [PATCH -next v3 1/2] mm/debug_vm_pgtable: Move {pmd/pud}_huge_tests out of CONFIG_TRANSPARENT_HUGEPAGE Message-Id: <20210509212654.e215ff71042b62704965ae01@linux-foundation.org> In-Reply-To: <20210419071820.750217-1-liushixin2@huawei.com> References: <20210419071820.750217-1-liushixin2@huawei.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 19 Apr 2021 15:18:19 +0800 Liu Shixin wrote: > The functions {pmd/pud}_set_huge and {pmd/pud}_clear_huge are not dependent > on THP. Hence move {pmd/pud}_huge_tests out of CONFIG_TRANSPARENT_HUGEPAGE. What is the actual effect of this? Better test coverage? Smaller kernel? Larger kernel? (I'm too lazy to figure this out and it should have been in the changelog anyway ;))