Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sun, 9 May 2021 21:46:03 -0700
From:   Andrew Morton <akpm@linux-foundation.org>
To:     glittao@gmail.com
Cc:     cl@linux.com, penberg@kernel.org, rientjes@google.com,
        iamjoonsoo.kim@lge.com, vbabka@suse.cz,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] mm/slub: use stackdepot to save stack trace in objects
Message-Id: <20210509214603.d2a5faaa3fe0d71c3517cb36@linux-foundation.org>
In-Reply-To: <20210414163434.4376-1-glittao@gmail.com>
References: <20210414163434.4376-1-glittao@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Wed, 14 Apr 2021 18:34:34 +0200 glittao@gmail.com wrote:

> Many stack traces are similar so there are many similar arrays.
> Stackdepot saves each unique stack only once.
> 
> Replace field addrs in struct track with depot_stack_handle_t handle.
> Use stackdepot to save stack trace.
> 
> The benefits are smaller memory overhead and possibility to aggregate
> per-cache statistics in the future using the stackdepot handle
> instead of matching stacks manually.

Which tree was this prepared against?  5.12's kmem_obj_info() is
significantly different from the version you were working on.

Please take a look, redo, retest and resend?  Thanks.