Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2312167pxj; Sun, 9 May 2021 23:04:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyQI9Ig63Hyi2c9XMYASu/QnDB4aJL/jwV3uKha/3rtGE7Xdv6/6rUJjLso6sAv+vgBYT2v X-Received: by 2002:a5d:9f01:: with SMTP id q1mr17216895iot.7.1620626644892; Sun, 09 May 2021 23:04:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620626644; cv=none; d=google.com; s=arc-20160816; b=dZbEr28MZVEZF8y4It+lgJSgpyxXAkdCQ+zqU7pPD8hJQc19Rfl76fmr36qoAKvujA kfhgizKCPaIE0eeTDCq4y7L7HQv/nmex8Z3R+zkaVl414/Rp4t9wcWt1aGEyGkFsI5Af nZtnrjP6lp6upqRv+l8Np2SyN8FElU4PygUZ72NJZdaO42JLANxYvn7fNB2z1qPIsBSP 0Fiq1Ac6vO33gBLHyV1s2QsY4nAiKT2uegwrZ2SpVXczVCe9a11hrpClFNBGW2NHmpUs z3pCk7m/lhi36pzOdWdck8mv+YjGsM3jvETjRU/LZ2YG0sHSgaLW9EOSzNMZ+qeCu8md uCvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-language:content-transfer-encoding :in-reply-to:mime-version:user-agent:date:message-id:organization :from:references:to:subject; bh=3otibce1fiDsIZ2BS6asZyY0WZE5x7RLuArsw/0/+AY=; b=fHJxws6NmeEc71t4X5ssTBdihNu+fWKzwxX3hGJ8lI8gE74T8Nmk+AkwOrXA1qHXGQ CMGTisEvKfXbAuk7djoAOsp8r6qIfviwXizEKBN4vIXSXWsuip7RnMzCTVM4gXVLeOVH iczTHrgzvyK4Y+TOxHac0VPgO/Lb+kquHzoFq5oYVaihQvy+JzUAK16m4+ysILXVAEj9 IYliLAMVMov4hhOJviblPn9qQW8KkfXicNca1f+9jegOqjJQ7q6g9e5EyLAiP+HSwRwX t1GlTLNJJSgQQDimXkEPBrDHG3jUgcGZDB3tmC5fy64MpePaeNBcmkwTJWgikSLKmDuo pU8Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o14si18178950iow.26.2021.05.09.23.03.52; Sun, 09 May 2021 23:04:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230009AbhEJGCv (ORCPT + 99 others); Mon, 10 May 2021 02:02:51 -0400 Received: from ivanoab7.miniserver.com ([37.128.132.42]:57892 "EHLO www.kot-begemot.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229653AbhEJGCu (ORCPT ); Mon, 10 May 2021 02:02:50 -0400 Received: from tun252.jain.kot-begemot.co.uk ([192.168.18.6] helo=jain.kot-begemot.co.uk) by www.kot-begemot.co.uk with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lfyz9-0006DY-Qs; Mon, 10 May 2021 06:01:44 +0000 Received: from madding.kot-begemot.co.uk ([192.168.3.98]) by jain.kot-begemot.co.uk with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lfyz7-0004m2-Bb; Mon, 10 May 2021 07:01:43 +0100 Subject: Re: [PATCH v2 0/1] drm/msm/dpu: Fix error return code in dpu_mdss_init() To: Zhen Lei , Rob Clark , Sean Paul , David Airlie , Daniel Vetter , linux-arm-msm , dri-devel , freedreno , linux-kernel References: <20210510031606.3112-1-thunder.leizhen@huawei.com> From: Anton Ivanov Organization: Cambridge Greys Message-ID: <9109a395-099b-ed14-4433-d4bf6dbf5cef@cambridgegreys.com> Date: Mon, 10 May 2021 07:01:41 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <20210510031606.3112-1-thunder.leizhen@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Spam-Score: -1.0 X-Spam-Score: -1.0 X-Clacks-Overhead: GNU Terry Pratchett Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/05/2021 04:16, Zhen Lei wrote: > v1 --> v2: > According to Anton Ivanov's review comments, detele the unnecessary local > variable initialization "ret = 0". > > > Zhen Lei (1): > drm/msm/dpu: Fix error return code in dpu_mdss_init() > > drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > I do not recall reviewing this. I think you got the wrong Anton Ivanov - I maintain UML so the previous revision hit someone's else inbox. -- Anton R. Ivanov Cambridgegreys Limited. Registered in England. Company Number 10273661 https://www.cambridgegreys.com/