Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2330016pxj; Sun, 9 May 2021 23:38:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxk7gIfH9vMalPntHJITqtSTYYGK/GGMidBT5x458HGiiP4derRqDFrHrPOvOFFhDFH5L0b X-Received: by 2002:a92:c54b:: with SMTP id a11mr6282455ilj.174.1620628713521; Sun, 09 May 2021 23:38:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620628713; cv=none; d=google.com; s=arc-20160816; b=cv71zTxR631QENkRIz8P3x1VRTV85n/PAK20tPXjybe+/kkLy8+Az/7Ygr81//lHpH TQlISTa+5MSmZoe5qCOTCCo9PrzJAgxPQJdxi5AOrGvfD8FyJDq2eoMiDJc+O7K1jm5/ 4yZlvLkanZA/c5pZaOE2WXZc9g0x/RSvSZoD/EaDDz+lQ9ZEWhaP9sNCHJBLBeSDb0sj 09UQZGQPW59ahxVL+Uvx6Ea75/9yqSS6wLSPtuH6IoG8XAAxEPTzHbcaQVqXJ/x0oC4b FhvWTT0AOFV9pV4DQfiUHqSJMb8QngVekOGiFog1ytqjSg8A6l4EoqxxkCKJ/B76DCIq b4uA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=tKY8w8y/AACF36R/faxPdF/fcIu6eyyU+gaJ7lFi4gU=; b=Kj0tKLfx4DXiqW47h8RGIgK8FW1iki+LNvFNnHZxNQepy3BnAOOf0KkWMcdnICYF5O 5fo3P4dPnyDpnzd4ewNiKuPgQSUvUMsdCgwTsqQpskYQfQLKgIk8rgazYjxkteAEdYi+ +JwWyVI53Po4aEHx9q9rhyC5HQmlQs9VWbRZdbe4aspJXMywdA81YNGV+dHKvqs2oGB/ N7UqYLca2FE80F8kyC8/qc66Sj5CsOJMEFt2AVoPBy7TmtERYCKyKoSVLRSzMm1zvX5W k1/yjEhGGewFUxzzFN1RtVJoOIj6uQnD1Yx3bdaq0MvHRtgopPjbtLBfT50XF13ZRayc kPkA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u12si14960166jak.73.2021.05.09.23.38.20; Sun, 09 May 2021 23:38:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230189AbhEJGio (ORCPT + 99 others); Mon, 10 May 2021 02:38:44 -0400 Received: from lucky1.263xmail.com ([211.157.147.134]:50254 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230002AbhEJGin (ORCPT ); Mon, 10 May 2021 02:38:43 -0400 Received: from localhost (unknown [192.168.167.130]) by lucky1.263xmail.com (Postfix) with ESMTP id 41CF7C8603; Mon, 10 May 2021 14:37:37 +0800 (CST) X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-ADDR-CHECKED4: 1 X-ANTISPAM-LEVEL: 2 X-ABS-CHECKED: 0 Received: from localhost.localdomain (unknown [58.22.7.114]) by smtp.263.net (postfix) whith ESMTP id P29694T140717190006528S1620628656593974_; Mon, 10 May 2021 14:37:37 +0800 (CST) X-IP-DOMAINF: 1 X-UNIQUE-TAG: X-RL-SENDER: jay.xu@rock-chips.com X-SENDER: xjq@rock-chips.com X-LOGIN-NAME: jay.xu@rock-chips.com X-FST-TO: heiko@sntech.de X-RCPT-COUNT: 7 X-SENDER-IP: 58.22.7.114 X-ATTACHMENT-NUM: 0 X-System-Flag: 0 From: Jianqun Xu To: heiko@sntech.de, linus.walleij@linaro.org, robh+dt@kernel.org Cc: linux-gpio@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Jianqun Xu Subject: [PATCH 7/7] gpio/rockchip: drop irq_gc_lock/irq_gc_unlock for irq set type Date: Mon, 10 May 2021 14:37:34 +0800 Message-Id: <20210510063734.506063-1-jay.xu@rock-chips.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210510063602.505829-1-jay.xu@rock-chips.com> References: <20210510063602.505829-1-jay.xu@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There has spin lock for irq set type already, so drop irq_gc_lock and irq_gc_unlock. Signed-off-by: Jianqun Xu --- drivers/gpio/gpio-rockchip.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpio/gpio-rockchip.c b/drivers/gpio/gpio-rockchip.c index 048e7eecddba..c9c55614bbef 100644 --- a/drivers/gpio/gpio-rockchip.c +++ b/drivers/gpio/gpio-rockchip.c @@ -406,7 +406,6 @@ static int rockchip_irq_set_type(struct irq_data *d, unsigned int type) irq_set_handler_locked(d, handle_level_irq); raw_spin_lock_irqsave(&bank->slock, flags); - irq_gc_lock(gc); level = rockchip_gpio_readl(bank, bank->gpio_regs->int_type); polarity = rockchip_gpio_readl(bank, bank->gpio_regs->int_polarity); @@ -461,7 +460,6 @@ static int rockchip_irq_set_type(struct irq_data *d, unsigned int type) rockchip_gpio_writel(bank, level, bank->gpio_regs->int_type); rockchip_gpio_writel(bank, polarity, bank->gpio_regs->int_polarity); out: - irq_gc_unlock(gc); raw_spin_unlock_irqrestore(&bank->slock, flags); return ret; -- 2.25.1