Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 10 May 2021 09:01:01 +0200
From:   Stefano Garzarella <sgarzare@redhat.com>
To:     Wan Jiabing <wanjiabing@vivo.com>
Cc:     "Michael S. Tsirkin" <mst@redhat.com>,
        Jason Wang <jasowang@redhat.com>,
        Stefan Hajnoczi <stefanha@redhat.com>,
        Max Gurtovoy <mgurtovoy@nvidia.com>,
        virtualization@lists.linux-foundation.org,
        linux-kernel@vger.kernel.org, kael_w@yeah.net
Subject: Re: [PATCH] vdpa_sim_blk: remove duplicate include of linux/blkdev.h
Message-ID: <20210510070101.iimcdu7zkmx5on6a@steredhat>
References: <20210510024307.7143-1-wanjiabing@vivo.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <20210510024307.7143-1-wanjiabing@vivo.com>
Precedence: bulk

On Mon, May 10, 2021 at 10:43:03AM +0800, Wan Jiabing wrote:
>In commit 7d189f617f83f ("vdpa_sim_blk: implement ramdisk behaviour")
>linux/blkdev.h was included here causing the duplicate include.
>Remove the later duplicate include.
>
>Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
>---
> drivers/vdpa/vdpa_sim/vdpa_sim_blk.c | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim_blk.c b/drivers/vdpa/vdpa_sim/vdpa_sim_blk.c
>index 5bfe1c281645..a790903f243e 100644
>--- a/drivers/vdpa/vdpa_sim/vdpa_sim_blk.c
>+++ b/drivers/vdpa/vdpa_sim/vdpa_sim_blk.c
>@@ -15,7 +15,6 @@
> #include <linux/blkdev.h>
> #include <linux/vringh.h>
> #include <linux/vdpa.h>
>-#include <linux/blkdev.h>
> #include <uapi/linux/virtio_blk.h>
>
> #include "vdpa_sim.h"
>-- 
>2.20.1
>

Ooops...

Thanks for fixing this!

Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>