Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <5bc44aace2fe7e1c91d8b35c8fe31e7134ceab2c.1620406852.git.christophe.jaillet@wanadoo.fr>
In-Reply-To: <5bc44aace2fe7e1c91d8b35c8fe31e7134ceab2c.1620406852.git.christophe.jaillet@wanadoo.fr>
From:   Chunyan Zhang <zhang.lyra@gmail.com>
Date:   Mon, 10 May 2021 15:18:07 +0800
Message-ID: <CAAfSe-srh_3S-AStLe7f+KuKQ2MY07OyhZ22nnEumE+uE8gUyA@mail.gmail.com>
Subject: Re: [PATCH] nvmem: sprd: Fix an error message
To:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc:     Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
        Orson Zhai <orsonzhai@gmail.com>,
        Baolin Wang <baolin.wang7@gmail.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Freeman Liu <freeman.liu@unisoc.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        kernel-janitors@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sat, 8 May 2021 at 01:02, Christophe JAILLET
<christophe.jaillet@wanadoo.fr> wrote:
>
> 'ret' is known to be 0 here.
> The expected error status is stored in 'status', so use it instead.
>
> Also change %d in %u, because status is an u32, not a int.
>
> Fixes: 096030e7f449 ("nvmem: sprd: Add Spreadtrum SoCs eFuse support")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

Thanks.
Acked-by: Chunyan Zhang <zhang.lyra@gmail.com>


> ---
>  drivers/nvmem/sprd-efuse.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nvmem/sprd-efuse.c b/drivers/nvmem/sprd-efuse.c
> index 5d394559edf2..e3e721d4c205 100644
> --- a/drivers/nvmem/sprd-efuse.c
> +++ b/drivers/nvmem/sprd-efuse.c
> @@ -234,7 +234,7 @@ static int sprd_efuse_raw_prog(struct sprd_efuse *efuse, u32 blk, bool doub,
>         status = readl(efuse->base + SPRD_EFUSE_ERR_FLAG);
>         if (status) {
>                 dev_err(efuse->dev,
> -                       "write error status %d of block %d\n", ret, blk);
> +                       "write error status %u of block %d\n", status, blk);
>
>                 writel(SPRD_EFUSE_ERR_CLR_MASK,
>                        efuse->base + SPRD_EFUSE_ERR_CLR);
> --
> 2.30.2
>