Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <f42e5936139f75968520cf76c359e079b49b1dcb.camel@pengutronix.de>
Subject: Re: [PATCH] reset: a10sr: add missing of_match_table reference
From:   Philipp Zabel <p.zabel@pengutronix.de>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
        Thor Thayer <thor.thayer@linux.intel.com>,
        linux-kernel@vger.kernel.org
Cc:     kernel test robot <lkp@intel.com>
Date:   Mon, 10 May 2021 09:50:34 +0200
In-Reply-To: <20210507112803.20012-1-krzysztof.kozlowski@canonical.com>
References: <20210507112803.20012-1-krzysztof.kozlowski@canonical.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
User-Agent: Evolution 3.30.5-1.1 
MIME-Version: 1.0
Precedence: bulk

On Fri, 2021-05-07 at 07:28 -0400, Krzysztof Kozlowski wrote:
> The driver defined of_device_id table but did not use it with
> of_match_table.  This prevents usual matching via devicetree and causes
> a W=1 warning:
> 
>   drivers/reset/reset-a10sr.c:111:34: warning:
>     ‘a10sr_reset_of_match’ defined but not used [-Wunused-const-variable=]
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Fixes: 627006820268 ("reset: Add Altera Arria10 SR Reset Controller")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
>  drivers/reset/reset-a10sr.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/reset/reset-a10sr.c b/drivers/reset/reset-a10sr.c
> index 7eacc89382f8..99b3bc8382f3 100644
> --- a/drivers/reset/reset-a10sr.c
> +++ b/drivers/reset/reset-a10sr.c
> @@ -118,6 +118,7 @@ static struct platform_driver a10sr_reset_driver = {
>  	.probe	= a10sr_reset_probe,
>  	.driver = {
>  		.name		= "altr_a10sr_reset",
> +		.of_match_table	= a10sr_reset_of_match,
>  	},
>  };
>  module_platform_driver(a10sr_reset_driver);

Thank you, applied to reset/next.

regards
Philipp