Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
In-Reply-To: <f070b59d5a1114d5a4e830346755c2b3f141cde5.1620560472.git.leonro@nvidia.com>
Subject: Re: [PATCH rdma-rc] RDMA/siw: Release xarray entry
From:   "Bernard Metzler" <BMT@zurich.ibm.com>
To:     "Leon Romanovsky" <leon@kernel.org>
Cc:     "Doug Ledford" <dledford@redhat.com>,
        "Jason Gunthorpe" <jgg@nvidia.com>,
        "Leon Romanovsky" <leonro@nvidia.com>,
        "linux-kernel" <linux-kernel@vger.kernel.org>,
        "linux-rdma" <linux-rdma@vger.kernel.org>
Date:   Mon, 10 May 2021 08:25:27 +0000
MIME-Version: 1.0
Sensitivity: 
Importance: Normal
References: <f070b59d5a1114d5a4e830346755c2b3f141cde5.1620560472.git.leonro@nvidia.com>
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Message-Id: <OFCA0BD73F.A7CD6605-ON002586D1.002E4672-002586D1.002E467F@notes.na.collabserv.com>
Precedence: bulk

-----"Leon Romanovsky" <leon@kernel.org> wrote: -----

>To: "Doug Ledford" <dledford@redhat.com>, "Jason Gunthorpe"
><jgg@nvidia.com>
>From: "Leon Romanovsky" <leon@kernel.org>
>Date: 05/09/2021 01:41PM
>Cc: "Leon Romanovsky" <leonro@nvidia.com>, "Bernard Metzler"
><bmt@zurich.ibm.com>, linux-kernel@vger.kernel.org,
>linux-rdma@vger.kernel.org
>Subject: [EXTERNAL] [PATCH rdma-rc] RDMA/siw: Release xarray entry
>
>From: Leon Romanovsky <leonro@nvidia.com>
>
>The xarray entry is allocated in siw=5Fqp=5Fadd(), but release was
>missed in case zero-sized SQ was discovered.
>
>Fixes: 661f385961f0 ("RDMA/siw: Fix handling of zero-sized Read and
>Receive Queues.")
>Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
>---
> drivers/infiniband/sw/siw/siw=5Fverbs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/infiniband/sw/siw/siw=5Fverbs.c
>b/drivers/infiniband/sw/siw/siw=5Fverbs.c
>index 917c8a919f38..3f175f220a22 100644
>--- a/drivers/infiniband/sw/siw/siw=5Fverbs.c
>+++ b/drivers/infiniband/sw/siw/siw=5Fverbs.c
>@@ -375,7 +375,7 @@ struct ib=5Fqp *siw=5Fcreate=5Fqp(struct ib=5Fpd *pd,
> 	else {
> 		/* Zero sized SQ is not supported */
> 		rv =3D -EINVAL;
>-		goto err=5Fout;
>+		goto err=5Fout=5Fxa;
> 	}
> 	if (num=5Frqe)
> 		num=5Frqe =3D roundup=5Fpow=5Fof=5Ftwo(num=5Frqe);
>--=20
>2.31.1
>
>
Thanks Leon!

Reviewed-by: Bernard Metzler <bmt@zurich.ibm.com>