Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: q2sC2mymTW5KRFMtbmwYS0BDSqGwxQEnAnja+iXUNXGSpb7lHXH1TCk293awHuLX6JzOcoT9qZ
 piM72N1oWJ5/BCOxoUTTqeHugqqXXl/wmap0O/bQqnHyZpi40FYJpUneVNQZ3KkuUtR/lAO6lu
 pIRWbL5I2BzkpwvfiCRj7zuDqlnvmW/LJQeNZx/kY2Xc+gr62pRQ8XKCRpRGhsLw5Dx2JqtSC8
 sj6RpMHRZeZr7NPcObzfkO1XDi9FHZp28oPnWHdhc2cI+xuIaKly8xO880oROKXvU/ZaCQxNti
 yUA=
From:   Johannes Thumshirn <Johannes.Thumshirn@wdc.com>
To:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
        "clm@fb.com" <clm@fb.com>
CC:     "josef@toxicpanda.com" <josef@toxicpanda.com>,
        "dsterba@suse.com" <dsterba@suse.com>,
        "linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] btrfs: Assign boolean values to a bool variable
Thread-Topic: [PATCH] btrfs: Assign boolean values to a bool variable
Thread-Index: AQHXEJjoiqW64Rl9Sk63MCR7+NNgEw==
Date:   Mon, 10 May 2021 09:37:58 +0000
Message-ID: <PH0PR04MB7416EC8C9020EAE3E074E21E9B549@PH0PR04MB7416.namprd04.prod.outlook.com>
References: <1614764728-14857-1-git-send-email-jiapeng.chong@linux.alibaba.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 9f23fa72-7e7f-4633-306a-08d913974bbd
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 May 2021 09:37:58.0130
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: YXdHTCR/xPxekebmgHvK8rpROuZboNI1YTFNq6C1n6hirUBzqFX7LprU08RNNl33VtnlVzAZDGOgVK9dtesVTBHI++onlldl5f0HQTrBQJI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR04MB7287
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 04/03/2021 02:51, Jiapeng Chong wrote:=0A=
> Fix the following coccicheck warnings:=0A=
> =0A=
> ./fs/btrfs/volumes.c:1462:10-11: WARNING: return of 0/1 in function=0A=
> 'dev_extent_hole_check_zoned' with return type bool.=0A=
> =0A=
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>=0A=
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>=0A=
> ---=0A=
>  fs/btrfs/volumes.c | 4 ++--=0A=
>  1 file changed, 2 insertions(+), 2 deletions(-)=0A=
> =0A=
> diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c=0A=
> index bc3b33e..995920f 100644=0A=
> --- a/fs/btrfs/volumes.c=0A=
> +++ b/fs/btrfs/volumes.c=0A=
> @@ -1458,8 +1458,8 @@ static bool dev_extent_hole_check_zoned(struct btrf=
s_device *device,=0A=
>  		/* Given hole range was invalid (outside of device) */=0A=
>  		if (ret =3D=3D -ERANGE) {=0A=
>  			*hole_start +=3D *hole_size;=0A=
> -			*hole_size =3D 0;=0A=
> -			return 1;=0A=
> +			*hole_size =3D false;=0A=
=0A=
=0A=
Erm, hole_size is u64 and not bool=0A=