Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2432724pxj; Mon, 10 May 2021 02:52:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzydO108M1hB8z/AXHoqJjchxv5GXMq3fR0M25wk7LGbyvV9D4pWlYzzU5uIzqAkVeJbBHq X-Received: by 2002:a05:6e02:1110:: with SMTP id u16mr2553840ilk.64.1620640337615; Mon, 10 May 2021 02:52:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620640337; cv=none; d=google.com; s=arc-20160816; b=n3JB5m62lFiqO2mgEJDfhJY5nZ2GKS9dXCw7uk7UUWH7zDNmwmxi2U4jN+NljT+YQQ x8qXlIgGQVhIA0dAxyv34hJR5N4tgzMYxQvjArqZ4Lfiy61kr8Dk7GAmJTkoYdv9qAtG 8TqRVggnWwHwjGnVN09g3lFfTMyCvpm9I/mOurSyOLWAgh28dxEBUxSmYsfpiyVELHdd 8yaGfNcrHLbebrTz4+19LQvgMgloRVpTxyCjdxIGTkawjD4bQ1R8iTBbx8lhGJVI61Fz 9Leu8LkeS0wr1JBbAePfs06FL+W3xfCKR1b1Kr/t+wbSy4qcE1+VNITAFycZnqEIq2Gl lUcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=sPbYFWmuZKDHkGmQrKP0ogEFV40mG/jEGbex4J82mwc=; b=U8MiLMDgCgpwwPYo7g6tJAYdPXyuJ3mQ29k6jrJN8NGIgEJekHuUBuajS7dZCTBwC3 qa1lWdAuh0vc8rgz511P8knzX76SazZIEQg5P+sYrC1Gpws0xfLCeO0cMsOnggkpyFHR xeNMvt/Dc9PInbcRQF5OFlTdHwkljbtwDTGp16ZafSZQwUD5rx51A4gvaOsnOMOIopyh czrs0No7HLBmho2cyghIu7Oilz98Zn2dmOSd2H5mGOqgzPE1Emijba1OelYPBXVOM6Cj LhhG1E1uZRe5bk2mZi15rDPGm3Qr7RAGkuWu3OcAvEChGE94/alInua5cKap6o/ga8oQ C6Pw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p11si15627770ilm.85.2021.05.10.02.52.05; Mon, 10 May 2021 02:52:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230151AbhEJJwV (ORCPT + 99 others); Mon, 10 May 2021 05:52:21 -0400 Received: from fgw23-7.mail.saunalahti.fi ([62.142.5.84]:14331 "EHLO fgw23-7.mail.saunalahti.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230477AbhEJJwL (ORCPT ); Mon, 10 May 2021 05:52:11 -0400 Received: from localhost (88-115-248-186.elisa-laajakaista.fi [88.115.248.186]) by fgw23.mail.saunalahti.fi (Halon) with ESMTP id 39560256-b175-11eb-8ccd-005056bdfda7; Mon, 10 May 2021 12:51:00 +0300 (EEST) From: Andy Shevchenko To: Pavel Machek , Andy Shevchenko , Amireddy Mallikarjuna reddy , Linus Walleij , =?UTF-8?q?Marek=20Beh=C3=BAn?= , Abanoub Sameh , Dan Murphy , Krzysztof Kozlowski , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Andy Shevchenko , Jacek Anaszewski Subject: [PATCH v1 02/28] leds: core: The -ENOTSUPP should never be seen by user space Date: Mon, 10 May 2021 12:50:19 +0300 Message-Id: <20210510095045.3299382-3-andy.shevchenko@gmail.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210510095045.3299382-1-andy.shevchenko@gmail.com> References: <20210510095045.3299382-1-andy.shevchenko@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Replace -ENOTSUPP by -EOPNOTSUPP when returning from exported function. Fixes: 13ae79bbe4c2 ("leds: core: Drivers shouldn't enforce SYNC/ASYNC brightness setting") Cc: Jacek Anaszewski Signed-off-by: Andy Shevchenko --- drivers/leds/led-core.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/leds/led-core.c b/drivers/leds/led-core.c index d56ff4939492..f962620a504f 100644 --- a/drivers/leds/led-core.c +++ b/drivers/leds/led-core.c @@ -289,6 +289,8 @@ EXPORT_SYMBOL_GPL(led_set_brightness_nosleep); int led_set_brightness_sync(struct led_classdev *led_cdev, unsigned int value) { + int ret; + if (led_cdev->blink_delay_on || led_cdev->blink_delay_off) return -EBUSY; @@ -297,7 +299,10 @@ int led_set_brightness_sync(struct led_classdev *led_cdev, unsigned int value) if (led_cdev->flags & LED_SUSPENDED) return 0; - return __led_set_brightness_blocking(led_cdev, led_cdev->brightness); + ret = __led_set_brightness_blocking(led_cdev, led_cdev->brightness); + if (ret == -ENOTSUPP) + return -EOPNOTSUPP; + return ret; } EXPORT_SYMBOL_GPL(led_set_brightness_sync); -- 2.31.1