Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2432807pxj; Mon, 10 May 2021 02:52:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz/5629AYK3OxLkoCoHaoPRQx709UTTbs82QknHSAOEF/09NPwuVrkE15a695QCw3ObwNz5 X-Received: by 2002:a6b:d213:: with SMTP id q19mr17036950iob.203.1620640347315; Mon, 10 May 2021 02:52:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620640347; cv=none; d=google.com; s=arc-20160816; b=k1QNXtZVIQOGsNy3lG9f3jsC3lSiTlCC6aQXlo03V9vydESzW1eyOXIQsW7hIqoXI5 FjIYTH3p3ziqHoIJbT3nlSAp//XDsg3u5/lkHJ1eaC4LC85EMcePt5kbl8QXZRh9roW1 1g6jcpV+DcgzfGyyo2zMqQeW/A/7nqu3iLTCp8IHPuFLs/usCcSgOo6oGIgq3YFoHbRY Bm9i+TuQu0vLOPfr9IUlGt85lJ6GO6sPYaKbvXo+prr+UYJ5yfMQT4tDFfbY4RncFcLU 877es++sVdrH+dXDwWz9VJ0NgvmllODY3GKA5O0uqHr1r2R1XkoX01YghReXwu39iKV3 PArw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=+BdQl+5A7XzZn34hQvFj4CBXvzTTFQrRUWuECXb3vk8=; b=tWzP6LEKkKuOtwmJEBozIeu5RYwxK8GFQj1pI0dwlHNOAhpUBcvOlykMLVUNjysK3U eLfbEHGUMyXbA2xh2H/r9DJ9ubL+Yuoc/PvWss/sxzxGGccT7AU5clj2u/W5/gsCZqkE 3lSRzeVD21PWEMY6XhH4kFAwR34WfzKEQsDXTdN/I5iQN9w7qoFf1eid2/CAah41Kzdq U6x1G4N6w5IujfUQ1+HLuuaYKg5fX8wmxRaw4jFIdDUfUI6M9xPNL7ANEd1DyqKK6ue3 tIGEVB0R831eHvkSV7c/1HbndlJMbcQPIkN+mf6jgeyRVij+vvp2/Y9BhSFyst3OWfdu YkJA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l11si269329ils.107.2021.05.10.02.52.15; Mon, 10 May 2021 02:52:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231126AbhEJJwQ (ORCPT + 99 others); Mon, 10 May 2021 05:52:16 -0400 Received: from fgw20-7.mail.saunalahti.fi ([62.142.5.81]:63648 "EHLO fgw20-7.mail.saunalahti.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230429AbhEJJwK (ORCPT ); Mon, 10 May 2021 05:52:10 -0400 Received: from localhost (88-115-248-186.elisa-laajakaista.fi [88.115.248.186]) by fgw20.mail.saunalahti.fi (Halon) with ESMTP id 38a60b87-b175-11eb-ba24-005056bd6ce9; Mon, 10 May 2021 12:50:58 +0300 (EEST) From: Andy Shevchenko To: Pavel Machek , Andy Shevchenko , Amireddy Mallikarjuna reddy , Linus Walleij , =?UTF-8?q?Marek=20Beh=C3=BAn?= , Abanoub Sameh , Dan Murphy , Krzysztof Kozlowski , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Andy Shevchenko , Jean-Jacques Hiblot Subject: [PATCH v1 01/28] leds: class: The -ENOTSUPP should never be seen by user space Date: Mon, 10 May 2021 12:50:18 +0300 Message-Id: <20210510095045.3299382-2-andy.shevchenko@gmail.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210510095045.3299382-1-andy.shevchenko@gmail.com> References: <20210510095045.3299382-1-andy.shevchenko@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Drop the bogus error code and let of_led_get() to take care about absent of_node. Fixes: e389240ad992 ("leds: Add managed API to get a LED from a device driver") Cc: Jean-Jacques Hiblot Signed-off-by: Andy Shevchenko --- drivers/leds/led-class.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/leds/led-class.c b/drivers/leds/led-class.c index 2e495ff67856..fa3f5f504ff7 100644 --- a/drivers/leds/led-class.c +++ b/drivers/leds/led-class.c @@ -285,10 +285,6 @@ struct led_classdev *__must_check devm_of_led_get(struct device *dev, if (!dev) return ERR_PTR(-EINVAL); - /* Not using device tree? */ - if (!IS_ENABLED(CONFIG_OF) || !dev->of_node) - return ERR_PTR(-ENOTSUPP); - led = of_led_get(dev->of_node, index); if (IS_ERR(led)) return led; -- 2.31.1