Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2433292pxj; Mon, 10 May 2021 02:53:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzUmNkT7xfqi0ZXuR74pMpi593DF0XE0R50/ciiRLyYR/zCrhFTF7g43tY5S75Wu/FvJtxd X-Received: by 2002:a5e:a704:: with SMTP id b4mr17826501iod.35.1620640404563; Mon, 10 May 2021 02:53:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620640404; cv=none; d=google.com; s=arc-20160816; b=KvAwzW5VCQgWlO+0wp2PW720lprO76QNMkQDau0rg6cDsDmuhOyFw7AcYznqiAtZ+S +pC2lZWkbT+6t7r7R8S19vNfU49uRwyUO0X1rLLlYkLk5WqwXj2R70/+KSte+wO3ePvN JENMxv+HZw07+8xAoYSNj14uQdzL3SvCpOEIPVpocJEiLGsUvGyzBwaUpl5nmebC3HgG S/K+tuPuC/+CNF2GjH0eqpjSs0gUPYkQ/9rGMfqvjJ98ajftcR6gkC6w4fXNeZ0+8mOQ 6ZfuO4MGDzRceZjhGIGsgTxo+lTwsMi0WVJqqYH/AR1VRjZfbokVNCo5eLOKZ/P9d0jw bdZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=GwnTEdpT87XZ8JZbwFnQb06psoKHBCDZa9nLoK9xW9o=; b=wNDrlDX/NBUsh0meXBMwm62FHmOPzN1BpsyX8ul8Yrk6auUMpaMEIRcs7iD4F9Cne7 gLJXI9D658PYShRob81w7TUJLqA89Y7daJpXoprseaFTIJz2G+CBQZxJtV9VndoEIF+b EP+9cGzaU5yvNGZPJS90OBkyh0Ho/SfC6Opi6f2CJJc4UukgJZFnBufeYuT7UZpzAkaC lProBbJE/W+Pbb65otIqYEcU4Cckfu7bWQ6V/hb0uU0kxczArQdRCj5LVfA2tXOPIYvj CFJsTlhf0HYixNjKubxh1HD5D62yL2oLNuqcHf6+IKon3DYyG9IAfpL+6jx5bpXaMiAD h02Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y5si14111086ill.127.2021.05.10.02.53.03; Mon, 10 May 2021 02:53:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231243AbhEJJxM (ORCPT + 99 others); Mon, 10 May 2021 05:53:12 -0400 Received: from fgw21-7.mail.saunalahti.fi ([62.142.5.82]:42564 "EHLO fgw21-7.mail.saunalahti.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231124AbhEJJwY (ORCPT ); Mon, 10 May 2021 05:52:24 -0400 Received: from localhost (88-115-248-186.elisa-laajakaista.fi [88.115.248.186]) by fgw21.mail.saunalahti.fi (Halon) with ESMTP id 3f0710d0-b175-11eb-9eb8-005056bdd08f; Mon, 10 May 2021 12:51:09 +0300 (EEST) From: Andy Shevchenko To: Pavel Machek , Andy Shevchenko , Amireddy Mallikarjuna reddy , Linus Walleij , =?UTF-8?q?Marek=20Beh=C3=BAn?= , Abanoub Sameh , Dan Murphy , Krzysztof Kozlowski , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Andy Shevchenko Subject: [PATCH v1 13/28] leds: lgm-sso: Convert to use list_for_each_entry*() API Date: Mon, 10 May 2021 12:50:30 +0300 Message-Id: <20210510095045.3299382-14-andy.shevchenko@gmail.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210510095045.3299382-1-andy.shevchenko@gmail.com> References: <20210510095045.3299382-1-andy.shevchenko@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Convert to use list_for_each_entry*() API insted of open coded variants. It saves few lines of code and makes iteasier to read and maintain. Signed-off-by: Andy Shevchenko --- drivers/leds/blink/leds-lgm-sso.c | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/leds/blink/leds-lgm-sso.c b/drivers/leds/blink/leds-lgm-sso.c index f44d6bf5a5b3..5505eda3c800 100644 --- a/drivers/leds/blink/leds-lgm-sso.c +++ b/drivers/leds/blink/leds-lgm-sso.c @@ -620,7 +620,6 @@ __sso_led_dt_parse(struct sso_led_priv *priv, struct fwnode_handle *fw_ssoled) struct device *dev = priv->dev; struct sso_led_desc *desc; struct sso_led *led; - struct list_head *p; const char *tmp; u32 prop; int ret; @@ -706,10 +705,8 @@ __sso_led_dt_parse(struct sso_led_priv *priv, struct fwnode_handle *fw_ssoled) __dt_err: fwnode_handle_put(fwnode_child); /* unregister leds */ - list_for_each(p, &priv->led_list) { - led = list_entry(p, struct sso_led, list); + list_for_each_entry(led, &priv->led_list, list) sso_led_shutdown(led); - } return -EINVAL; } @@ -844,14 +841,12 @@ static int intel_sso_led_probe(struct platform_device *pdev) static int intel_sso_led_remove(struct platform_device *pdev) { struct sso_led_priv *priv; - struct list_head *pos, *n; - struct sso_led *led; + struct sso_led *led, *n; priv = platform_get_drvdata(pdev); - list_for_each_safe(pos, n, &priv->led_list) { - list_del(pos); - led = list_entry(pos, struct sso_led, list); + list_for_each_entry_safe(led, n, &priv->led_list, list) { + list_del(&led->list); sso_led_shutdown(led); } -- 2.31.1