Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2433295pxj; Mon, 10 May 2021 02:53:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxwbFnQRcXXyfItqeVGXzRJ6ABe/7xUQ8drU0R9+Je064Ag12g+qaR29UFmY9iNaxZsdcpq X-Received: by 2002:a02:b793:: with SMTP id f19mr20443581jam.128.1620640404774; Mon, 10 May 2021 02:53:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620640404; cv=none; d=google.com; s=arc-20160816; b=Y/IVWjDBZQeenV/+CHZYtYvBZ9YvpDHfs2myM6LYVLl9zE6WImQY2NsEqvHBVStpig 6hgCIB9J+qjlPKOeC8DKXk5LdaRB35QZetGe0w/M5SdTyBonqkbF4rV+8JN8P3QbKoxV 2PpJAkKHZBkrpZHazzycjzSDB0j2qlESGQkcd9p5DF8HqKR7jlghtUVblyOjT7tQwtHr aSxGA3/3xm4ttvfzzmMDg4WiAmogedRsdF7FWdFO9a4jS+cZGVGutQ2WPPa5V6qKpo22 tIf6iacOkbvl/LGNCtIbXmfu2DjM+MW3n1XaLz4RjHGntf4xG53PdgIcxPAWQVje2wHS pHgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=r3aWjQ5MF91GwsbDtb+r16/Fja92YYKL0UdTTWgvKSU=; b=c9aGw9n7MT1k905ajB7gfPVKgyGeX/cBRe3r1xBv4WrdWTh936vUL5sGXf8kiCReEc mBa3rV4ek3HYM+4wdZQvkPw0EOUFj6AobPG286IQiETYs95CjHaNJIbqO6BjG82FjBBe QjvLCMDOLyPpQx9Yj0SjKWUMstgQrGaiSncrdYM9FXVD78OoEbNPvTDyWKQmdH62Wiq+ 5kWUVJi6bY63hOb2q034EPCkYYKyI0m06HvF/C390l0orIzXdtOWc4SoccHlu7+1XNJT vnnJ0LuL+iK/CLjUmylGVd1r5rLh+0CBoG615pMO2uN/dibGWS3DRYiPkVEovnQnmgcQ jEWg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o7si11988573ill.156.2021.05.10.02.53.10; Mon, 10 May 2021 02:53:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231338AbhEJJxU (ORCPT + 99 others); Mon, 10 May 2021 05:53:20 -0400 Received: from fgw22-7.mail.saunalahti.fi ([62.142.5.83]:17315 "EHLO fgw22-7.mail.saunalahti.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230500AbhEJJwU (ORCPT ); Mon, 10 May 2021 05:52:20 -0400 Received: from localhost (88-115-248-186.elisa-laajakaista.fi [88.115.248.186]) by fgw22.mail.saunalahti.fi (Halon) with ESMTP id 3e60dc10-b175-11eb-88cb-005056bdf889; Mon, 10 May 2021 12:51:08 +0300 (EEST) From: Andy Shevchenko To: Pavel Machek , Andy Shevchenko , Amireddy Mallikarjuna reddy , Linus Walleij , =?UTF-8?q?Marek=20Beh=C3=BAn?= , Abanoub Sameh , Dan Murphy , Krzysztof Kozlowski , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Andy Shevchenko Subject: [PATCH v1 12/28] leds: lgm-sso: Drop duplicate NULL check for GPIO operations Date: Mon, 10 May 2021 12:50:29 +0300 Message-Id: <20210510095045.3299382-13-andy.shevchenko@gmail.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210510095045.3299382-1-andy.shevchenko@gmail.com> References: <20210510095045.3299382-1-andy.shevchenko@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Since GPIO operations are NULL-aware, we don't need to duplicate this check. Remove it and fold the rest of the code. Signed-off-by: Andy Shevchenko --- drivers/leds/blink/leds-lgm-sso.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/leds/blink/leds-lgm-sso.c b/drivers/leds/blink/leds-lgm-sso.c index a7f2e5436ba2..f44d6bf5a5b3 100644 --- a/drivers/leds/blink/leds-lgm-sso.c +++ b/drivers/leds/blink/leds-lgm-sso.c @@ -259,7 +259,7 @@ static void sso_led_brightness_set(struct led_classdev *led_cdev, 1 << desc->pin); } - if (!desc->hw_trig && led->gpiod) + if (!desc->hw_trig) gpiod_set_value(led->gpiod, val); } -- 2.31.1