Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2441974pxj; Mon, 10 May 2021 03:07:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxNTl/EvAr1jR4Yz6M6Hl1Tno74pv6iFMu4xAp8oXpPSi3hcZKBHasKwvG8/2oGebpNyOrD X-Received: by 2002:a05:6e02:5ac:: with SMTP id k12mr21934656ils.173.1620641248594; Mon, 10 May 2021 03:07:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620641248; cv=none; d=google.com; s=arc-20160816; b=ZJWxnhGcjvK+9igNQ/uYSc0PB7SvPjy6wZ/yRPPjPQbTLCGbFF+iWMcy3WxE2/Dxde QdCo3nzKi2SYoukJj8Ou7CbY8nkKU6SJ/dkeoBHQ3lA7OG0jxRz+H1w6jOXnrSWGwDZa F1wxKvpchmLXbWsFcRgYKg6lJz+AOgnuWegMJX7Ih6y9RJYRsmbdV9XmmjjJKVVrQ/IY 2s4Av7NpBO3rPXDiz47lbiU/f2bjWC+PMgvCztAy9vztE5aKcIxr9Mig5FBx3S/CBDy3 qAEKQF8B2izzydWWe/xaP1VJ5c6prHkPLFKJSgo13AiUT50374Pvpg+udQxHmEkB3FMI cC9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=EkxevIyYAHeubxlcXcG2reu1xsSh4NLpOVpqURmSABA=; b=e1RYOeB+SVkzHxMXTc6LZn6gSBUKvJAos5qzHk4zdVl/X3q2QYvbynioiKGF2HQTjP RDQpiS39KBg22O/oGyx5zxZKn0VlMMGfXtM/S3OrFoNVp6x8rWDo6mqnDkMdiGgFBCIM qQVLucHdKimJKdGD+Ctwo6wdTwBdvA+iIKz7q4DJCDCjnxYeO2Iy5UGAao3iU13EeziV jv0nwzTClPgN0tFiBCr73HBs5t6Thg158TvjcGa3q5WVjq/9H0++e+uNfD9lETXtlexw H8SM4G2G0GVAG+FbZaxNsIx70hurdcjyDc2Y615GZUhEu9murS36w7odK48CMBsynIiY PeLg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a23si15921291jap.18.2021.05.10.03.07.15; Mon, 10 May 2021 03:07:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230254AbhEJKHL (ORCPT + 99 others); Mon, 10 May 2021 06:07:11 -0400 Received: from foss.arm.com ([217.140.110.172]:53376 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230103AbhEJKHK (ORCPT ); Mon, 10 May 2021 06:07:10 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D657915BE; Mon, 10 May 2021 03:06:05 -0700 (PDT) Received: from [10.163.77.48] (unknown [10.163.77.48]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6FB2A3F719; Mon, 10 May 2021 03:06:02 -0700 (PDT) Subject: Re: [PATCH] mm/thp: Make ARCH_ENABLE_SPLIT_PMD_PTLOCK dependent on PGTABLE_LEVELS > 2 To: Peter Zijlstra Cc: linux-mm@kvack.org, akpm@linux-foundation.org, Heiko Carstens , Vasily Gorbik , Thomas Gleixner , Ingo Molnar , x86@kernel.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org References: <1620621345-29176-1-git-send-email-anshuman.khandual@arm.com> <20210510085313.GB5618@worktop.programming.kicks-ass.net> From: Anshuman Khandual Message-ID: <843e545a-ca0c-6a1e-2ab0-28ccca182400@arm.com> Date: Mon, 10 May 2021 15:36:29 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210510085313.GB5618@worktop.programming.kicks-ass.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/10/21 2:23 PM, Peter Zijlstra wrote: > On Mon, May 10, 2021 at 10:05:45AM +0530, Anshuman Khandual wrote: >> - select ARCH_ENABLE_SPLIT_PMD_PTLOCK if X86_64 || X86_PAE >> + select ARCH_ENABLE_SPLIT_PMD_PTLOCK if (PGTABLE_LEVELS > 2) && (X86_64 || X86_PAE) > > It's still very early on a Monday, but IIRC this new condition is > identical to the pre-existing one. Did not get it, could you please elaborate ?