Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2457736pxj; Mon, 10 May 2021 03:32:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz6Y1pn0LPSYvByVI1MW+NgCjpdro7ilMdfPz6Yz6NwH8o+p6gGcYGhWbXTCdE112BkwzEP X-Received: by 2002:a17:906:b191:: with SMTP id w17mr25199442ejy.200.1620642746857; Mon, 10 May 2021 03:32:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620642746; cv=none; d=google.com; s=arc-20160816; b=qJcYsR2U8Iu0sfg+eEUeMdLe7YmMwBnVoBuTEavZ2TGCFehQtG6FQRIEyU0ffLIRv5 /roQ0bsluc/N8RFuEgDQXj1eVqucxOK1ru7nr26YzCpaJDBwodhO6Txml+M91kv7082u +JZmXogAw81sKE9yqI90+h6CObBeZbz4n4+XK2b31IwFQPvtszv6QxYP3uQMuitjdIeI bPA7QMnq9RRBz8HHvQtMTf6UwERhHW+MYqL696SGfWcJw8r4uCcmWPUGEIN4f0DqkrJQ aQ46LZJLvc7Pk3hXaFlUxJS/pnUJZ+taXUfTpAeZCQFwBCrstfdG4ZDwJ2D0RMQ8F0bV MhzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=QPCYTGSxSFxrqYo6/bNHtXQAEA/MFhtbCEXFpLt8isM=; b=kRAzjgsoXnky6ObXSR9KWW2mlsg78vz8jlXUOd4GPAMVKm2Xx+BDZ2YKD+yQharV9Z i3xU56pqfk1TB1nUezDMK5oxfNfSgCTFt9O08A7K4G8tQbRDaviiJ1/IEnQRxjiILSRb Kc55gwHP5uY78KbOcnt2W25D3S41UCcDp+Fk84NUyq/zJky9R+OzasQtkLWOPU5vET7b qXtkToCwUMMGoL4s/TiT+RqQhRcdcHZqks6phzNtqAgnIbREVWcwicynaHHGs6Wkcox1 U6H4PX8ZkfCMoTu/mZGlIrKZur9efmpsH0exD1M4dDjzwJCDzTHKh//QpYEbU+6jknOX rZSQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=dBwMb0U6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i18si3440299ejz.246.2021.05.10.03.32.03; Mon, 10 May 2021 03:32:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=dBwMb0U6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231916AbhEJKbE (ORCPT + 99 others); Mon, 10 May 2021 06:31:04 -0400 Received: from mail.kernel.org ([198.145.29.99]:59860 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231458AbhEJK1w (ORCPT ); Mon, 10 May 2021 06:27:52 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id F36A461075; Mon, 10 May 2021 10:26:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1620642403; bh=1EWvrNcYRMZNejusgByiFhHZ5oaQkZq+5SS5tOUEu3E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dBwMb0U68DOJXEZMOZNJOr/0t93GjtHWnQ1Svf1Kf85sup3A7L4PWkf36FohMMa4X T8ANMbSxTTI00VrUleNJiDQPBz0lGutsoOg0KjYvSo4CtjbrFFglLjiro+OxoJW+pl Ho/VyYJIx4PlgQVOIL9eIGDcN2oX46hDpDlW30M0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Julian Braha , Hans Verkuil , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 5.4 079/184] media: drivers: media: pci: sta2x11: fix Kconfig dependency on GPIOLIB Date: Mon, 10 May 2021 12:19:33 +0200 Message-Id: <20210510101952.772355437@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210510101950.200777181@linuxfoundation.org> References: <20210510101950.200777181@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Julian Braha [ Upstream commit 24df8b74c8b2fb42c49ffe8585562da0c96446ff ] When STA2X11_VIP is enabled, and GPIOLIB is disabled, Kbuild gives the following warning: WARNING: unmet direct dependencies detected for VIDEO_ADV7180 Depends on [n]: MEDIA_SUPPORT [=y] && GPIOLIB [=n] && VIDEO_V4L2 [=y] && I2C [=y] Selected by [y]: - STA2X11_VIP [=y] && MEDIA_SUPPORT [=y] && MEDIA_PCI_SUPPORT [=y] && MEDIA_CAMERA_SUPPORT [=y] && PCI [=y] && VIDEO_V4L2 [=y] && VIRT_TO_BUS [=y] && I2C [=y] && (STA2X11 [=n] || COMPILE_TEST [=y]) && MEDIA_SUBDRV_AUTOSELECT [=y] This is because STA2X11_VIP selects VIDEO_ADV7180 without selecting or depending on GPIOLIB, despite VIDEO_ADV7180 depending on GPIOLIB. Signed-off-by: Julian Braha Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/pci/sta2x11/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/pci/sta2x11/Kconfig b/drivers/media/pci/sta2x11/Kconfig index 011b766f0bff..d613feee8176 100644 --- a/drivers/media/pci/sta2x11/Kconfig +++ b/drivers/media/pci/sta2x11/Kconfig @@ -2,6 +2,7 @@ config STA2X11_VIP tristate "STA2X11 VIP Video For Linux" depends on STA2X11 || COMPILE_TEST + select GPIOLIB if MEDIA_SUBDRV_AUTOSELECT select VIDEO_ADV7180 if MEDIA_SUBDRV_AUTOSELECT select VIDEOBUF2_DMA_CONTIG depends on PCI && VIDEO_V4L2 && VIRT_TO_BUS -- 2.30.2