Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2458114pxj; Mon, 10 May 2021 03:33:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyninQCeeColzJMluQrrqiF+9YKUohXvQxrBeNe8t5l9s6nV67Z5hBF89m4RkiqurrfKuas X-Received: by 2002:a05:6402:5106:: with SMTP id m6mr28715933edd.212.1620642786257; Mon, 10 May 2021 03:33:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620642786; cv=none; d=google.com; s=arc-20160816; b=d+LNWly9f1rT7k5e3vhFZsbIWuQr8S9QrpdKp2UuiKlqUyW503sRu6dhRyesLD0iPd 84dxrq2+AmbUiuaAN3SzxiV9UYqGCaUvvan5abUBqMSgrLWDibhmgQJ7z/rwO6JXXeKS pnarqJU1TBcU6v3PyfC4m+gPVybxOAS9hnT1L4F/ekMyovAgTYBP5WHM/aW2flWoJaN9 54ULEMpLTE4NPnawyMaVpzt5RGPIOMJtkAv/Mq3u1uw3xdVh5wT8OCnu4/uBZnrbK7qe 6LViV67v1nSJIYuncUzVoNYyOijDhKLZ/z+wfIwsC/Ip90iFiLM012DThi13RKbZCk2i wmeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=lwbl7vPmgWjH819aukpb2cW+dP0cKfcJQMaZ0dVLjgI=; b=a6XUfbWsjlGqoNb669bJ0lqqwSXpFdaSJ2vacSlZ3Al1vHy7tfqJkBFpY9iS6tdMy0 12fROCtFBD+tIFu1s0PWkUOSNttehjCe0WzfT/rLX3Hd0xi8ZIp21r5UWMLvv7+fC6Jc 3bPWHap8ejKon6/NTEF3Ompo/+OOuacQFshB9I+H9ipRNYAflFRAFvCW+BVtMVdRKgcw p39fZO1XSk7sUxX9Cc67P/A8LYJqF8SHBdCLiXqDnUUwxbzFZWIDZ8kSZ6REtBAXgl8F mP20W3QGflsqF4G5YndLuSC/TdqQdyFKmAspFieujpNsCJ2Hi6obdg03rIjENMiYkp0Q +WmA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="C1x//rPD"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u17si12946077ejf.662.2021.05.10.03.32.43; Mon, 10 May 2021 03:33:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="C1x//rPD"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231855AbhEJKar (ORCPT + 99 others); Mon, 10 May 2021 06:30:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:60844 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231656AbhEJK1v (ORCPT ); Mon, 10 May 2021 06:27:51 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 1DDDD61090; Mon, 10 May 2021 10:26:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1620642398; bh=mLGJBaQAfuA/+IOhEU4qh/p0ufoOZWLFfpTLJIhCyOo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=C1x//rPDhWYhLQjiDO+YjrtZltT9UZWzN88mF3Gld3OotT4bbaqfY+q1Y7nTCGPMT sOp0Go+Y86TvBIgFxCgHdeglmM4DXIKuhzL5b6xgx1MQk8fBYKgkXaZA5hd9MZQ8Ej NtD4eed9OT8m4kP4q3YZ88GP3+MNEVsKgUwQO3zI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Mike Christie , Johannes Thumshirn , Chaitanya Kulkarni , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 5.4 077/184] scsi: target: pscsi: Fix warning in pscsi_complete_cmd() Date: Mon, 10 May 2021 12:19:31 +0200 Message-Id: <20210510101952.709768438@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210510101950.200777181@linuxfoundation.org> References: <20210510101950.200777181@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Chaitanya Kulkarni [ Upstream commit fd48c056a32ed6e7754c7c475490f3bed54ed378 ] This fixes a compilation warning in pscsi_complete_cmd(): drivers/target/target_core_pscsi.c: In function ‘pscsi_complete_cmd’: drivers/target/target_core_pscsi.c:624:5: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body] ; /* XXX: TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE */ Link: https://lore.kernel.org/r/20210228055645.22253-5-chaitanya.kulkarni@wdc.com Reviewed-by: Mike Christie Reviewed-by: Johannes Thumshirn Signed-off-by: Chaitanya Kulkarni Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/target/target_core_pscsi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/target/target_core_pscsi.c b/drivers/target/target_core_pscsi.c index 5a047ce77bc0..55fe93296deb 100644 --- a/drivers/target/target_core_pscsi.c +++ b/drivers/target/target_core_pscsi.c @@ -620,8 +620,9 @@ static void pscsi_complete_cmd(struct se_cmd *cmd, u8 scsi_status, unsigned char *buf; buf = transport_kmap_data_sg(cmd); - if (!buf) + if (!buf) { ; /* XXX: TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE */ + } if (cdb[0] == MODE_SENSE_10) { if (!(buf[3] & 0x80)) -- 2.30.2