Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932131AbWJWLry (ORCPT ); Mon, 23 Oct 2006 07:47:54 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932130AbWJWLry (ORCPT ); Mon, 23 Oct 2006 07:47:54 -0400 Received: from agent.admingilde.org ([213.95.21.5]:61674 "EHLO mail.admingilde.org") by vger.kernel.org with ESMTP id S932129AbWJWLrx (ORCPT ); Mon, 23 Oct 2006 07:47:53 -0400 Date: Mon, 23 Oct 2006 13:47:36 +0200 From: Martin Waitz To: Josef Sipek Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, torvalds@osdl.org, viro@ftp.linux.org.uk, hch@infradead.org, jack@suse.cz Subject: Re: [PATCH 01 of 23] VFS: change struct file to use struct path Message-ID: <20061023114736.GA15167@admingilde.org> Mail-Followup-To: Josef Sipek , Andrew Morton , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, torvalds@osdl.org, viro@ftp.linux.org.uk, hch@infradead.org, jack@suse.cz References: <20061021002200.4731cdeb.akpm@osdl.org> <20061021072807.GF30620@filer.fsl.cs.sunysb.edu> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="T4sUOijqQbZv57TR" Content-Disposition: inline In-Reply-To: <20061021072807.GF30620@filer.fsl.cs.sunysb.edu> X-PGP-Fingerprint: B21B 5755 9684 5489 7577 001A 8FF1 1AC5 DFE8 0FB2 User-Agent: Mutt/1.5.9i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1335 Lines: 47 --T4sUOijqQbZv57TR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable hoi :) On Sat, Oct 21, 2006 at 03:28:07AM -0400, Josef Sipek wrote: > > why? >=20 > It's little cleaner than having two pointers. In general, there is a numb= er > of users of dentry-vfsmount pairs in the kernel, and struct path nicely > wraps it. Sure, but you can split the patch up: First, change struct file and introduce the #defines so that everything still works as before. If this is accepted upstream, you can start to move other kernel code to use the new names. If all active trees have finally moved to only use the new name, then you can remove the #define. --=20 Martin Waitz --T4sUOijqQbZv57TR Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (GNU/Linux) iD8DBQFFPKvYj/Eaxd/oD7IRAi3zAJ9qSZFesBjkZrGY7oji3jOwz4QLmACfb4wV M0NkF7IKaZtHjtr+0RJAlPY= =X3Lv -----END PGP SIGNATURE----- --T4sUOijqQbZv57TR-- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/