Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2465518pxj; Mon, 10 May 2021 03:45:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJweaNIWUZaBKyCPRycbpMSSAKwZs6eyUto1xy+E/+dk8rI0NhpTQJlgSIC95GHkOCc878pm X-Received: by 2002:a17:906:f113:: with SMTP id gv19mr25965956ejb.237.1620643559242; Mon, 10 May 2021 03:45:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620643559; cv=none; d=google.com; s=arc-20160816; b=By6UpgDhb6Nqb39Uo/a1vXPDaLogPpZdsWi2VmZTcNKSWZ2wd0HTCa6gzmgd9MTY8t 3SCcdhRGss5T1uQ1oNGVXa+cFIDeY6J+VvPS+NuPCFkDfNVIBqbEHIhCBXakOWO5TEp5 AgEumEZjntYtfD71W7RiiY+2mGuYCd8FCrNnFbqzMfnNqYIOXka1uCfMfOX82M3kizsm Hc7LtZKi8NFQsRTR0sFK7FY174NGDubsPucS0K5d/pXl2oHCbPygCpLzA8DoNt+aHw48 6fk47OrTwTPldS55erH7SVNr81MHG2MqSI6wOcjyiJWAJhHc7MIeZ1/acDZVKsqHaIL3 y+0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=84CoAcq6zGqLGD5ItHj6bSCwHa6MovOfNtKQRAASsd0=; b=U+xe5WL2ho+rH9W3qEYVBNdJwAMa4ghWC0z/CBuRM4ShaVpi3kQaaR5CEeG1eOOxxB Qa6k5m18AwvhbGQZ3+Jxxw0iUUzckSw7SPV1JC7n+3QXrCigZMhG74UCWmKORyV0jHu6 3ojtMpHL25eZCX5auaFOMVUhbatkwibVuHGfWlq33NIIrEwQuANK9n15Qy+v5bYuGEhQ bpJeowDRF8+2+V2PKWPGyhNrY2TzrB5ZxlnqARUQzkFijeeWtbQTgXNVs+oqx2w+Q9ny Di0/1uVNgO+L5KogN79X3AI5nXc1dbPKO8xfcXDerb7rFv++u7W624dXuZg3pvBdn3yq yZXQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=E6rFVFXg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id pg16si12341186ejb.269.2021.05.10.03.45.34; Mon, 10 May 2021 03:45:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=E6rFVFXg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232675AbhEJKod (ORCPT + 99 others); Mon, 10 May 2021 06:44:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:40904 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232047AbhEJKfy (ORCPT ); Mon, 10 May 2021 06:35:54 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id B090461626; Mon, 10 May 2021 10:29:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1620642543; bh=/LogAFM6LnjxbranjfGc8t6rHE8tXrgUBthEQ/zuHOU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=E6rFVFXg7ptyi13ItJqvyv5m6d4qfkagJp94fzGtTmJxaJHEwUtIzrqSHBpHgaobK AxZjRkVukf4ziEcQIpCS0LHrRsh+3wv4rdP0sXc3MJTj4rDm2tcuYb7fEJTx41Jp2w i7xebVLjjq4Eg7cDuuQDs8Bx4r4EGXlcysWGtuzc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Luis Henriques , Stefan Hajnoczi , Vivek Goyal , Miklos Szeredi Subject: [PATCH 5.4 138/184] virtiofs: fix memory leak in virtio_fs_probe() Date: Mon, 10 May 2021 12:20:32 +0200 Message-Id: <20210510101954.673106194@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210510101950.200777181@linuxfoundation.org> References: <20210510101950.200777181@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Luis Henriques commit c79c5e0178922a9e092ec8fed026750f39dcaef4 upstream. When accidentally passing twice the same tag to qemu, kmemleak ended up reporting a memory leak in virtiofs. Also, looking at the log I saw the following error (that's when I realised the duplicated tag): virtiofs: probe of virtio5 failed with error -17 Here's the kmemleak log for reference: unreferenced object 0xffff888103d47800 (size 1024): comm "systemd-udevd", pid 118, jiffies 4294893780 (age 18.340s) hex dump (first 32 bytes): 00 00 00 00 ad 4e ad de ff ff ff ff 00 00 00 00 .....N.......... ff ff ff ff ff ff ff ff 80 90 02 a0 ff ff ff ff ................ backtrace: [<000000000ebb87c1>] virtio_fs_probe+0x171/0x7ae [virtiofs] [<00000000f8aca419>] virtio_dev_probe+0x15f/0x210 [<000000004d6baf3c>] really_probe+0xea/0x430 [<00000000a6ceeac8>] device_driver_attach+0xa8/0xb0 [<00000000196f47a7>] __driver_attach+0x98/0x140 [<000000000b20601d>] bus_for_each_dev+0x7b/0xc0 [<00000000399c7b7f>] bus_add_driver+0x11b/0x1f0 [<0000000032b09ba7>] driver_register+0x8f/0xe0 [<00000000cdd55998>] 0xffffffffa002c013 [<000000000ea196a2>] do_one_initcall+0x64/0x2e0 [<0000000008f727ce>] do_init_module+0x5c/0x260 [<000000003cdedab6>] __do_sys_finit_module+0xb5/0x120 [<00000000ad2f48c6>] do_syscall_64+0x33/0x40 [<00000000809526b5>] entry_SYSCALL_64_after_hwframe+0x44/0xae Cc: stable@vger.kernel.org Signed-off-by: Luis Henriques Fixes: a62a8ef9d97d ("virtio-fs: add virtiofs filesystem") Reviewed-by: Stefan Hajnoczi Reviewed-by: Vivek Goyal Signed-off-by: Miklos Szeredi Signed-off-by: Greg Kroah-Hartman --- fs/fuse/virtio_fs.c | 1 + 1 file changed, 1 insertion(+) --- a/fs/fuse/virtio_fs.c +++ b/fs/fuse/virtio_fs.c @@ -667,6 +667,7 @@ static int virtio_fs_probe(struct virtio out_vqs: vdev->config->reset(vdev); virtio_fs_cleanup_vqs(vdev, fs); + kfree(fs->vqs); out: vdev->priv = NULL;