Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2466394pxj; Mon, 10 May 2021 03:47:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzu5c994Y5aU4XR5/nsj3p/O+uTDf7n71EKYKaIHKlBoYKCdZ7r1v333eN6Odl7Mfr3dS+2 X-Received: by 2002:a05:6e02:10cf:: with SMTP id s15mr21452428ilj.302.1620643635391; Mon, 10 May 2021 03:47:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620643635; cv=none; d=google.com; s=arc-20160816; b=ww5DHurHFUBXs75VaVL7cLYgl7Iw60uy5WV2GE9AbNYcqnWDj0ysnA37JFwBeSza7X ZDED8YRZRjhE1JE6G1DxvOli5PZxxC0oCh89n10tmCcLPDkReTUwwUrQ6hRWTHMcNbfP M5MKRPV94Fx0YbhB5pjwu0cK0smPAmukxdgDMo92Aj44WucrcGtuDiRWpFtVsn7vmj33 qHzk+HXS8IkNWoC9mQAlXRBHuUbeliuovoXYiIic3ckc4qrO4sNJTBeCMXsnkDhdyWdp h6fyDy1E8IVXCp6c7loULN2lE3UJB3dmPjp8W7nWDlYxx5C5wDWPBJVcZPFybk/HZaWk xCSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=OoDeJ5TGhmsZb16lty/OaLwvKMIybOz4Ewi/xcVV6F4=; b=OqYWS+p/vLHb9Y9BM7GEL1NRLA7u1Q0ydcwSRM8GmwUb37zXQjM7qmMf1M1GNAzlgA 5Su1HaE+l+yEO8ykM0AxwvL46T1X6dlotfrSS3/0w5570ip+SlaPIBfpUY53tzMGd5d0 qO8AaI+DUzM8jL2Vpre2e6bgQ5BaADaGpvjG5fy+b3ol1oOgV4yTXmJeZbyV118bPikq 5DKP9YjIQgHFAs+ZSCN6uFNqhYN/bVXQi7gZwRtO44JS5g4BCRC/soH/GizSTPkk4a9g JHKBL/pw3VoVS7WqtCvuLq8aTzGgOz7BWw5eOEST4dEp2L4mej8f591tigEZg5ag0Pu6 o0yg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i25si5424462ila.96.2021.05.10.03.47.02; Mon, 10 May 2021 03:47:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232789AbhEJKrN (ORCPT + 99 others); Mon, 10 May 2021 06:47:13 -0400 Received: from out30-130.freemail.mail.aliyun.com ([115.124.30.130]:48254 "EHLO out30-130.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231727AbhEJKjG (ORCPT ); Mon, 10 May 2021 06:39:06 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R231e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e01424;MF=jiapeng.chong@linux.alibaba.com;NM=1;PH=DS;RN=6;SR=0;TI=SMTPD_---0UYOWhGt_1620643067; Received: from j63c13417.sqa.eu95.tbsite.net(mailfrom:jiapeng.chong@linux.alibaba.com fp:SMTPD_---0UYOWhGt_1620643067) by smtp.aliyun-inc.com(127.0.0.1); Mon, 10 May 2021 18:38:00 +0800 From: Jiapeng Chong To: mark@fasheh.com Cc: jlbec@evilplan.org, joseph.qi@linux.alibaba.com, ocfs2-devel@oss.oracle.com, linux-kernel@vger.kernel.org, Jiapeng Chong Subject: [PATCH v2] ocfs2: Reomve err less than zero check Date: Mon, 10 May 2021 18:37:42 +0800 Message-Id: <1620643062-124920-1-git-send-email-jiapeng.chong@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Because enum dlm_status starts from 0, the check for err < 0 is always false. Clean up the following coccicheck warning: fs/ocfs2/dlm/dlmdebug.c:222 dlm_errname() warn: unsigned 'err' is never less than zero. fs/ocfs2/dlm/dlmdebug.c:214 dlm_errmsg() warn: unsigned 'err' is never less than zero. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- Changes in v2: -Update commit log. fs/ocfs2/dlm/dlmdebug.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/ocfs2/dlm/dlmdebug.c b/fs/ocfs2/dlm/dlmdebug.c index d442cf5..817914d 100644 --- a/fs/ocfs2/dlm/dlmdebug.c +++ b/fs/ocfs2/dlm/dlmdebug.c @@ -211,7 +211,7 @@ void dlm_print_one_lock(struct dlm_lock *lockid) const char *dlm_errmsg(enum dlm_status err) { - if (err >= DLM_MAXSTATS || err < 0) + if (err >= DLM_MAXSTATS) return dlm_errmsgs[DLM_MAXSTATS]; return dlm_errmsgs[err]; } @@ -219,7 +219,7 @@ const char *dlm_errmsg(enum dlm_status err) const char *dlm_errname(enum dlm_status err) { - if (err >= DLM_MAXSTATS || err < 0) + if (err >= DLM_MAXSTATS) return dlm_errnames[DLM_MAXSTATS]; return dlm_errnames[err]; } -- 1.8.3.1