Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2467999pxj; Mon, 10 May 2021 03:50:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJweHIeU7Ibrhl0GYggSUxjfJMn82dBPfqcw20YkGpUG3y7CWbkURz9sPEFQlBkE23cWHqMD X-Received: by 2002:a05:6e02:1aa7:: with SMTP id l7mr20793705ilv.307.1620643804762; Mon, 10 May 2021 03:50:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620643804; cv=none; d=google.com; s=arc-20160816; b=pE15XFqe8XnSW7yPJ1eA+hpFX9oBc7CEUVC9zKeOjsDuFbPu4cmgSd1u0lpHl4Eszr 92xOhKRped1CjzfAUoLFRk/ltVqffUDXfJMEpkpF2mUxAHYH1T0DnvBoSRHWgwE88A7f Krtd6t93RaVIpt1rH+DNXamWBX6CsIXI3zPe1tzN2Q1yB75tKWwHXJQhqqH45dP101Lm QDuNccCS0MLq08cMNIhkqiqb1TmjDu4aVfuYMQyIQwCrtGv2ixycSku5n9S0IKV5gn5B MYFMZC8k5NYVBmabeAgRkQAV94QUnbfH4NdVXcXB6LGKc0SpFJ2u4qctMRavhV+iOFAh Vy4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=GmnYlAd8bCG4l7ZSCluxolTl9DDGGegmpT7YAgIKGIQ=; b=s7imoAlljM6BfSyfiihyojFGE4Aaf0V/aY0cmpKHJdB+IAIbbc9lD7KjHube5HhkB3 mlExvN+oeBACqLnXVz/mjdmHmPkyw/jsR3tK9Q+aAl4MHDwrvQ1ShVVZBoG373pcFqqH y1mqV+WMKJMzKzcPzgY5SO1xaeP7t2XAluHKp2aBGJLBKel+7bz2M/fj6ixyMCNohwGq /NxHCOFGkdHwAxAdlZ0i6mJSGKYS3yHX0gI82MJ7P3rswyaLTG+FFG8Xyb9b8lq9dIRz s2M3RRrvxnrC/XxcRgVCfenTYmCA3eyp5+TU8HSMQP/cMGXThF99IkB2QR3eGwp2d+r5 8bfg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=jugv8Vem; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c16si15628933ilh.10.2021.05.10.03.49.52; Mon, 10 May 2021 03:50:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=jugv8Vem; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230437AbhEJKrs (ORCPT + 99 others); Mon, 10 May 2021 06:47:48 -0400 Received: from mail.kernel.org ([198.145.29.99]:48506 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232592AbhEJKju (ORCPT ); Mon, 10 May 2021 06:39:50 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 7FBD1616EB; Mon, 10 May 2021 10:30:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1620642642; bh=p0/9GNzb2Z1L70sg3pa0/wbT0izlpUcsgxaub4LvsEU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jugv8VemxV6o8vzQ8lMmVVnhbqebyv6zKdyjxelrkrXw4bm3cS2d7w9Q/TYEi7qfr To43kiM/HYTOa0zJvisBYzGkUBFF9FyWZ05FJ3FqcVbkF/TELW15jCWhIoIOt9md1y OckJYHHTX51SB7d5fmHIbPkxYfv03H4YIebGDwH8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Marek Vasut , Amitkumar Karwar , Angus Ainslie , "David S. Miller" , Jakub Kicinski , Kalle Valo , Karun Eagalapati , Martin Kepplinger , Sebastian Krzyszkowiak , Siva Rebbagondla , netdev@vger.kernel.org Subject: [PATCH 5.4 178/184] rsi: Use resume_noirq for SDIO Date: Mon, 10 May 2021 12:21:12 +0200 Message-Id: <20210510101955.950375595@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210510101950.200777181@linuxfoundation.org> References: <20210510101950.200777181@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Marek Vasut commit c434e5e48dc4e626364491455f97e2db0aa137b1 upstream. The rsi_resume() does access the bus to enable interrupts on the RSI SDIO WiFi card, however when calling sdio_claim_host() in the resume path, it is possible the bus is already claimed and sdio_claim_host() spins indefinitelly. Enable the SDIO card interrupts in resume_noirq instead to prevent anything else from claiming the SDIO bus first. Fixes: 20db07332736 ("rsi: sdio suspend and resume support") Signed-off-by: Marek Vasut Cc: Amitkumar Karwar Cc: Angus Ainslie Cc: David S. Miller Cc: Jakub Kicinski Cc: Kalle Valo Cc: Karun Eagalapati Cc: Martin Kepplinger Cc: Sebastian Krzyszkowiak Cc: Siva Rebbagondla Cc: netdev@vger.kernel.org Cc: stable@vger.kernel.org Signed-off-by: Kalle Valo Link: https://lore.kernel.org/r/20210327235932.175896-1-marex@denx.de Signed-off-by: Greg Kroah-Hartman --- drivers/net/wireless/rsi/rsi_91x_sdio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/wireless/rsi/rsi_91x_sdio.c +++ b/drivers/net/wireless/rsi/rsi_91x_sdio.c @@ -1511,7 +1511,7 @@ static int rsi_restore(struct device *de } static const struct dev_pm_ops rsi_pm_ops = { .suspend = rsi_suspend, - .resume = rsi_resume, + .resume_noirq = rsi_resume, .freeze = rsi_freeze, .thaw = rsi_thaw, .restore = rsi_restore,