Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2468385pxj; Mon, 10 May 2021 03:50:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw1eMgx+LGCohDLPXN7QuCJdQN1GiIdVEMr7FOWc/bh1oCpSeqthOLufmnOeliDesDUBcAS X-Received: by 2002:a05:6e02:e43:: with SMTP id l3mr21424691ilk.130.1620643847354; Mon, 10 May 2021 03:50:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620643847; cv=none; d=google.com; s=arc-20160816; b=PXN38TUp2w5+2MZCW7hdnLpbi34dyKj1q/L5kL8hone5pylPVOXRRyf4xsM+s+EStL dX4hYnJJ4Qle5JtM5C+4r4AQOOH0vHMiSGFiSA+684UVMRHNNcdADWdmSt9YKnRTegv7 NAKVpnDtgSVoZm3apNwfPTo4L+hV2vKQa0nZBKIpHLNiq3p6ADpOmOCiKcn+2px6wLz4 cQVfKhLsaOxRvw/ZgMITP6Qow1PuMymIEdfH+Rr4/RQqcCAcpFlgTR1W4W8FcqOxWrGL 1VRrN6VOIWGg9NdxYzyNs75X/XR7NWeSD6OKs8/PCUCrTTW+Y8M0+w6HKD4/Rx7NPd4n RDZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=8WvRXSEGpSUDg3IGDbDU5C/I0KQ7VoBNfW56KR9/HXU=; b=c3uHdhHE9luxsOhTVnT4YCMTf3bXI0GoTtsymYYOCLKmTMfXd9WiXK79TrFGLMQfQU NympVmZ6kTZs8JsZtITSzL/CKU235MbYe80VeCZnOX27UtQw8BmxSYhXJMzTYDlZH7dg SeSZR+ho0wa+ozS0mMGdx558tRfBzB1XP5yGAcmzARfDn7kVfIhusiW4S1nqIyI/pSW3 YBVsof5vcRFCbChGcE20q3GhAhC1Ca73JBr2FaeHjUyUGRYDTsfoOogiST9HuomXU3Ag xW1trm2MyooQ/21ZbDET1YJz83lWt3h5BP4rrqDFTJGw+jG1h0ZwnYd1GFh0OcrWP1t7 fd1g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=YwI5bbF0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m13si14841377ilq.150.2021.05.10.03.50.35; Mon, 10 May 2021 03:50:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=YwI5bbF0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231620AbhEJKsq (ORCPT + 99 others); Mon, 10 May 2021 06:48:46 -0400 Received: from mail.kernel.org ([198.145.29.99]:52048 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232773AbhEJKkX (ORCPT ); Mon, 10 May 2021 06:40:23 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3EE7B6195D; Mon, 10 May 2021 10:30:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1620642655; bh=NnXrD86QDaepdkZjCNN7ZgN4nfylby90UqM9E5K6xzI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YwI5bbF02NSTnrnCqN6pE9+HqH2ThAaAUuCK3oWkER3TXwImfbAZhTDQJOJZKVp2D wUUxvu8bxW9b0vbM76uspvcveuiWN5KqYZc4vla3eJ/CI8qAorQWaMnOIbZBvmjn+0 7IhcPzq9P9oEUOWi+meSDtb4TpDntic1j/BMMcak= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Joe Thornber , Ming-Hung Tsai , Mike Snitzer Subject: [PATCH 5.4 182/184] dm space map common: fix division bug in sm_ll_find_free_block() Date: Mon, 10 May 2021 12:21:16 +0200 Message-Id: <20210510101956.083756405@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210510101950.200777181@linuxfoundation.org> References: <20210510101950.200777181@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Joe Thornber commit 5208692e80a1f3c8ce2063a22b675dd5589d1d80 upstream. This division bug meant the search for free metadata space could skip the final allocation bitmap's worth of entries. Fix affects DM thinp, cache and era targets. Cc: stable@vger.kernel.org Signed-off-by: Joe Thornber Tested-by: Ming-Hung Tsai Signed-off-by: Mike Snitzer Signed-off-by: Greg Kroah-Hartman --- drivers/md/persistent-data/dm-space-map-common.c | 2 ++ 1 file changed, 2 insertions(+) --- a/drivers/md/persistent-data/dm-space-map-common.c +++ b/drivers/md/persistent-data/dm-space-map-common.c @@ -339,6 +339,8 @@ int sm_ll_find_free_block(struct ll_disk */ begin = do_div(index_begin, ll->entries_per_block); end = do_div(end, ll->entries_per_block); + if (end == 0) + end = ll->entries_per_block; for (i = index_begin; i < index_end; i++, begin = 0) { struct dm_block *blk;