Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: dO626D+qe7JfNuO9RaYBDytqi8zE0woQQ0EhT1WM/rLfaacxIVzoWVGr2qHDJRXzyOKRfAw7Hi
 0SIvGgahYBU/BcXoOTeJph2c1/JGFiqWpR8fSpWVYVyfMCbky02OLc8L6LqajvXmL05PxoNsxZ
 0y62vtMM6Ca5X6Lm0QO8vqo9CKbDDL+olcB3SaJGRlivSQxMSCO2J/9WbxverscHw0eLtcZvRn
 14UinTDrUaXFsFvHomP+cR8nbfNtA8A1AXeWIp9XGfUBErHV4QgOmB0aT9jMR6RSYN25h7zjK2
 R8w=
From:   Avri Altman <Avri.Altman@wdc.com>
To:     Ulf Hansson <ulf.hansson@linaro.org>,
        "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
        Adrian Hunter <adrian.hunter@intel.com>
CC:     Linus Walleij <linus.walleij@linaro.org>,
        Wolfram Sang <wsa+renesas@sang-engineering.com>,
        Shawn Lin <shawn.lin@rock-chips.com>,
        Masami Hiramatsu <masami.hiramatsu@linaro.org>,
        "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 2/2] mmc: core: Add support for cache ctrl for SD cards
Thread-Topic: [PATCH 2/2] mmc: core: Add support for cache ctrl for SD cards
Thread-Index: AQHXQohQmJ5aCkIH3kCczJUde/3xEqrcbNXwgAAf84A=
Date:   Mon, 10 May 2021 10:41:34 +0000
Message-ID: <DM6PR04MB6575FC67AED514877921AC99FC549@DM6PR04MB6575.namprd04.prod.outlook.com>
References: <20210506145829.198823-1-ulf.hansson@linaro.org>
 <20210506145829.198823-3-ulf.hansson@linaro.org>
 <DM6PR04MB6575E3D63982278D2F1CA022FC549@DM6PR04MB6575.namprd04.prod.outlook.com>
In-Reply-To: <DM6PR04MB6575E3D63982278D2F1CA022FC549@DM6PR04MB6575.namprd04.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: cdd1877a-76ed-40dd-3234-08d913a02e83
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 May 2021 10:41:34.5068
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: e4N+D2Fzj956D9MKKfA+UB1GJ4w1cMUm5VymxUfPCfm1qIhzwvSjsa+07cAxiD1ytj0eM3CTke4S8PT6QneZcQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR04MB4153
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> > +       if (!err)
> > +               card->ext_perf.feature_enabled |=3D SD_EXT_PERF_CACHE;
> Maybe
> If (err)
>     card->ext_perf.feature_enabled &=3D ~SD_EXT_PERF_CACHE;
>=20
> and move to out: to catch the sd_write_ext_reg err ?
Please ignore - got mixed up with card->ext_perf.feature_support...

Sorry,
Avri

>=20
> > +
> > +out:
> > +       kfree(reg_buf);
> > +       return err;
> > +}
> > +
> >  /*
> >   * Handle the detection and initialisation of a card.
> >   *
> > @@ -1442,6 +1531,13 @@ static int mmc_sd_init_card(struct mmc_host
> > *host, u32 ocr,
> >                         goto free_card;
> >         }
> >
> > +       /* Enable internal SD cache if supported. */
> > +       if (card->ext_perf.feature_support & SD_EXT_PERF_CACHE) {
> > +               err =3D sd_enable_cache(card);
> > +               if (err)
> > +                       goto free_card;
> If cache enablement failed, is it worthwhile to bail out?
> Maybe disabling the cache with the appropriate message is enough?
>=20
> > +       }
> > +
> >         if (host->cqe_ops && !host->cqe_enabled) {
> >                 err =3D host->cqe_ops->cqe_enable(host, card);
> >                 if (!err) {
> > @@ -1694,6 +1790,8 @@ static const struct mmc_bus_ops mmc_sd_ops =3D
> {
> >         .alive =3D mmc_sd_alive,
> >         .shutdown =3D mmc_sd_suspend,
> >         .hw_reset =3D mmc_sd_hw_reset,
> > +       .cache_enabled =3D sd_cache_enabled,
> > +       .flush_cache =3D sd_flush_cache,
> >  };
>=20
> I would expect 2 more patches in this series:
>  - flush cache on power down
>  - cache disablement events?
>=20
> Thanks,
> Avri