Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2483089pxj; Mon, 10 May 2021 04:11:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwXvfSTeSqiklWkUFqI84N5BoLm3+s1MTagRS1wenlos3cqg+GvPoh9PBp24kMUbMZ+9fDa X-Received: by 2002:a92:da06:: with SMTP id z6mr21875175ilm.129.1620645060969; Mon, 10 May 2021 04:11:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620645060; cv=none; d=google.com; s=arc-20160816; b=ut9HdDWAPaHbI3zSRGOBtkYsIBcYpwtDUjGNLRzOk6iwmaLxPkB5CcpnhDO6DE0cx9 5yN7vGFc5DjqqQeibVmxP9FkygQOeVOMO9Ylg7AzG74uVKJ7OALoqu5JJls7JQ1yB3xr 5KElBZOIwdTRAL+6lmDhXkXySCuHI4qIahaY90eQHNFYskoWd6tZi/NmYAKP2aF39Fk8 QgMtGnuZFlAtjfxzrjG10EYiHb+GMSMB5VToKMp9H5mF8wTHNNrK6wOjCIFLunjDfLOE 9iqDbatvalJ/U8gWgAXq0iQl/GV5Bu2KtANIh3BmxB9NpmZv2wMetT+rKnBPgmfLekJc kKqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=DmJtPD1JWPBfeNPiJiH/YiXEP99MIgwy589MBcsBZDY=; b=uwSfvpU4+nsLyrwNDkcKg4bAkYE68vyQayvxHc/2N6DkdjNm30UW1cSrVHMFsaSFNJ R8v/Pk93FAnLMntHsKcmWYuzf0zopaEvrTyYMyUt6PPwqYQ1prsNlDKalQc794xAna48 1/DfWBHm1CM3JkqgtjHR0JJsKRxrKuXwdx5BSL8kFsH4LZw6/tqcXa9B1sDBcs4lPluW 2gpuYDIibYsr1alBOe2MqWqV0kj2drex8iwpk0sEH3FANzoHCAVByry4PNx6RkbFdkCQ zStPu0J9qARE95mdOCIvYEFN73irE1PZYVTHXibiFtzWEegRZV1Ksnb5fOE6q7yVs/M4 Cbxw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Y0B8G4cF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i21si20871684iov.29.2021.05.10.04.10.48; Mon, 10 May 2021 04:11:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Y0B8G4cF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234116AbhEJLEc (ORCPT + 99 others); Mon, 10 May 2021 07:04:32 -0400 Received: from mail.kernel.org ([198.145.29.99]:58270 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233382AbhEJKpm (ORCPT ); Mon, 10 May 2021 06:45:42 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9AF5B619A7; Mon, 10 May 2021 10:36:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1620642978; bh=3QPNUUFwutbpp8um8I+PiqU57KH5wx8UBnfck6xHl2k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Y0B8G4cFy3KqaFJXMlCSgx7JTNjCvO2ij1T87AWxywkMhQxyqHhB6fUJSrFHqLHmB AFRbXOu86VlBOzclvzdI7pvNlX1P7RgJvT6eBYxQ+KevMAbav0sNad2f8I/o0SormB ihA/bIjSL5B8m4+pjJYWmDbWxSXyWXpMAPIB8g0M= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Julian Braha , Hans Verkuil , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 5.10 130/299] media: drivers: media: pci: sta2x11: fix Kconfig dependency on GPIOLIB Date: Mon, 10 May 2021 12:18:47 +0200 Message-Id: <20210510102009.270578043@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210510102004.821838356@linuxfoundation.org> References: <20210510102004.821838356@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Julian Braha [ Upstream commit 24df8b74c8b2fb42c49ffe8585562da0c96446ff ] When STA2X11_VIP is enabled, and GPIOLIB is disabled, Kbuild gives the following warning: WARNING: unmet direct dependencies detected for VIDEO_ADV7180 Depends on [n]: MEDIA_SUPPORT [=y] && GPIOLIB [=n] && VIDEO_V4L2 [=y] && I2C [=y] Selected by [y]: - STA2X11_VIP [=y] && MEDIA_SUPPORT [=y] && MEDIA_PCI_SUPPORT [=y] && MEDIA_CAMERA_SUPPORT [=y] && PCI [=y] && VIDEO_V4L2 [=y] && VIRT_TO_BUS [=y] && I2C [=y] && (STA2X11 [=n] || COMPILE_TEST [=y]) && MEDIA_SUBDRV_AUTOSELECT [=y] This is because STA2X11_VIP selects VIDEO_ADV7180 without selecting or depending on GPIOLIB, despite VIDEO_ADV7180 depending on GPIOLIB. Signed-off-by: Julian Braha Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/pci/sta2x11/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/pci/sta2x11/Kconfig b/drivers/media/pci/sta2x11/Kconfig index 4dd98f94a91e..27bb78513631 100644 --- a/drivers/media/pci/sta2x11/Kconfig +++ b/drivers/media/pci/sta2x11/Kconfig @@ -3,6 +3,7 @@ config STA2X11_VIP tristate "STA2X11 VIP Video For Linux" depends on PCI && VIDEO_V4L2 && VIRT_TO_BUS && I2C depends on STA2X11 || COMPILE_TEST + select GPIOLIB if MEDIA_SUBDRV_AUTOSELECT select VIDEO_ADV7180 if MEDIA_SUBDRV_AUTOSELECT select VIDEOBUF2_DMA_CONTIG select MEDIA_CONTROLLER -- 2.30.2