Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2489931pxj; Mon, 10 May 2021 04:21:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyutQLmCw/zf4NoeQrbEUsWnfXDjKioqDEvn/SUCGT3waw9aK4Ji5YXVsv5QUWi+oYERmV6 X-Received: by 2002:a05:6e02:8f2:: with SMTP id n18mr20070220ilt.299.1620645676744; Mon, 10 May 2021 04:21:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620645676; cv=none; d=google.com; s=arc-20160816; b=ZHhWcf6v+vx1hy39E9BqB8RzaY8mF68PLPc1pBYZzL7bBvUIKKSx5XjeFLlr+o/zLf M8TwZZFtFDwG1ql/fwZJhsJOE5YaStEW+lu2luo1DCsw/RU/Hsm3b8RBNWiLMV8GAiLw Mb8fXLbbB0vkmi9iIHLeWVLnOGsFWLMOSyEDWTW6sjaYmqv6LUl7l86THtQHNuRaDt6A BL5hB6ZlYx0coTMoCSe/z+F4MPILD1J5uxBC/MMLP9swSbqmJEzEaIY0wMqGCHKHWYPr YF0XVeDARQg+bsSnQE2+QpJ74Mc5FEZEaQDkdS+5FMBtMyW7Z9Iz9+GvnTjWoWhXurhR 9asw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=+91fx94ydy610uKDEJBxyKFm+wthB3YVc33fAkg60Ws=; b=Doi5WAsDQCNc8vTHEgd2u5hSqllmvDQFf0wyPYCErvMN/MUSTJ/NraFpP14RjxN1vH +YvNpxHCp0LrTLKPqihH4ZPjpcjam6/2IIc2GFiNKHM+zsIUpOtVinBGAySAaEFgP3/y F62PBQSLL3yP35zUrddFSCotP+Spmj/gRoveGn5Jc8ItUoDvXwAk0EG7Nt7zjQ0WDxdL ByUEVx4lL5eosALVoNZ8pnxmJV9Ki2WySHddSFF+kIePQdU9jCWD5ebpqqS9ylrpWRlx xcuvbicIuSkJwoGTSM2XLYkC058lkD2FnJF5MsGg7AY0PXTKgPSYJpgwPNKnq9nSYl11 GAoA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=WoKTXIEP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o21si10647042jat.63.2021.05.10.04.21.04; Mon, 10 May 2021 04:21:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=WoKTXIEP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238790AbhEJLSs (ORCPT + 99 others); Mon, 10 May 2021 07:18:48 -0400 Received: from mail.kernel.org ([198.145.29.99]:52794 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233884AbhEJKze (ORCPT ); Mon, 10 May 2021 06:55:34 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 7399661C26; Mon, 10 May 2021 10:42:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1620643372; bh=Ga0GcZJ15+mCFyWQygC1n0QxlS2LBSHB5Xti+h6bYng=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WoKTXIEPe7kNFG3/6ElGn+c+9Q7mrsiWZrnQ23B9t5FnawjhwCQggqtCi8BDDWygp nUYtBDGUlnYSyK4WIMRv9mL+gMud3GHJe6c+afPOLBn6z3L2dVtLnikbBjsZCdjARl KhjQPw+fL18L2jIDGkPiCDvQ5tDPPg8C03NzVyDw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Marek Vasut , Amitkumar Karwar , Angus Ainslie , "David S. Miller" , Jakub Kicinski , Kalle Valo , Karun Eagalapati , Martin Kepplinger , Sebastian Krzyszkowiak , Siva Rebbagondla , netdev@vger.kernel.org Subject: [PATCH 5.10 289/299] rsi: Use resume_noirq for SDIO Date: Mon, 10 May 2021 12:21:26 +0200 Message-Id: <20210510102014.466602818@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210510102004.821838356@linuxfoundation.org> References: <20210510102004.821838356@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Marek Vasut commit c434e5e48dc4e626364491455f97e2db0aa137b1 upstream. The rsi_resume() does access the bus to enable interrupts on the RSI SDIO WiFi card, however when calling sdio_claim_host() in the resume path, it is possible the bus is already claimed and sdio_claim_host() spins indefinitelly. Enable the SDIO card interrupts in resume_noirq instead to prevent anything else from claiming the SDIO bus first. Fixes: 20db07332736 ("rsi: sdio suspend and resume support") Signed-off-by: Marek Vasut Cc: Amitkumar Karwar Cc: Angus Ainslie Cc: David S. Miller Cc: Jakub Kicinski Cc: Kalle Valo Cc: Karun Eagalapati Cc: Martin Kepplinger Cc: Sebastian Krzyszkowiak Cc: Siva Rebbagondla Cc: netdev@vger.kernel.org Cc: stable@vger.kernel.org Signed-off-by: Kalle Valo Link: https://lore.kernel.org/r/20210327235932.175896-1-marex@denx.de Signed-off-by: Greg Kroah-Hartman --- drivers/net/wireless/rsi/rsi_91x_sdio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/wireless/rsi/rsi_91x_sdio.c +++ b/drivers/net/wireless/rsi/rsi_91x_sdio.c @@ -1513,7 +1513,7 @@ static int rsi_restore(struct device *de } static const struct dev_pm_ops rsi_pm_ops = { .suspend = rsi_suspend, - .resume = rsi_resume, + .resume_noirq = rsi_resume, .freeze = rsi_freeze, .thaw = rsi_thaw, .restore = rsi_restore,