Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2495437pxj; Mon, 10 May 2021 04:30:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwpJ/Zju+M+IGUstIx10EFnhTKI3dyFDnDrL5AOQdKq1PMw6s0ERFRl9SCChkwnfp6Y+NOD X-Received: by 2002:a92:d287:: with SMTP id p7mr15000449ilp.165.1620646209328; Mon, 10 May 2021 04:30:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620646209; cv=none; d=google.com; s=arc-20160816; b=mSKztbINWAIn8O8EAiI2pWlgFhmg8vkjdMjvQ19+cNgT8GmwPuft0dAq1X9+UZCBK2 PIM3zQJVanFHqiB75S7p/ivfAectDFd5qV/cCC3Z0tiJz7NM7PJM4W2HNGiHDdNuh6nd DVdj4RiP7dDXSrF+kKTBV7c5cexWGOMyE5WoeKkQvg1JQMxUmlK3Kha6XsZFKtH9tVzH mOLtPXjPF214EVNe9YwBsA8fxIfv7Jo3xA2gz3ERfruSFoPOZwQeTRNBh7bDd82TxRxv VaAfR2SmeSqODFlAindFccT67vF8ijPGXCcWQD60gdF5/Racs2h/HUETqP/wQw8vz2Xd 5Whw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=7Gj+si2Akkyw7gOIafJ/mrYWugT2bnqlR53LGPtPkbI=; b=Q/fUWF9nX6MbT0sPlTKy8Cw/hjRUhGLs0A0A6MDKEdCIkeKOwcLP5kY4YtCwmXhVp6 dp9h33rrjDESATEAuEjjUCeGFqD9tRP47HeoK8YrS9FL7EqNlxw8gfdb373qEgC/QdQ/ GEJi4ypeDsFsQes/IIrjkOwKsJZRV0BR52lemgwfyZgeLlCcfejwpCFWPFKUiTNWxrPm KTice0VPJxUq8qo47faImEOdCGTQIfFOyJ4c2nQeMnBy9Xkfsmo2crbx7ZYtWrVu6dXG jKu4YtMyo40d6mS+ftqPc9Spp9ZaEAz5ODuWTXYwt1Wi+VtrikIb9D84M6D0tcn7yPVg Mhjw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=oQ2UhpJk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o8si15167657ilu.133.2021.05.10.04.29.55; Mon, 10 May 2021 04:30:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=oQ2UhpJk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236838AbhEJLZU (ORCPT + 99 others); Mon, 10 May 2021 07:25:20 -0400 Received: from mail.kernel.org ([198.145.29.99]:52744 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234282AbhEJK4H (ORCPT ); Mon, 10 May 2021 06:56:07 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5FD1C6162C; Mon, 10 May 2021 10:45:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1620643508; bh=NP0EJ8kuHK4TxSdYpQDX7lgasfB84oNqD23GsylnWUE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=oQ2UhpJkp4KmIXdd8OFMdGUvzEzCTGIXMlcNH5lXZTFHGBwh+1N8Bbdhr7S512y4U hdP5XdupraGprvDypXK57eKKLUaf1WAU5+kdQ+DHo7HBAXS/9vpd3b3A0hDr0Qae9n bhY/9uKDwTfqIvMepe588jUzrUMsgUh9NS7RsbSo= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Avri Altman , Adrian Hunter , Ulf Hansson Subject: [PATCH 5.11 043/342] mmc: block: Update ext_csd.cache_ctrl if it was written Date: Mon, 10 May 2021 12:17:13 +0200 Message-Id: <20210510102011.532421979@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210510102010.096403571@linuxfoundation.org> References: <20210510102010.096403571@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Avri Altman commit aea0440ad023ab0662299326f941214b0d7480bd upstream. The cache function can be turned ON and OFF by writing to the CACHE_CTRL byte (EXT_CSD byte [33]). However, card->ext_csd.cache_ctrl is only set on init if cache size > 0. Fix that by explicitly setting ext_csd.cache_ctrl on ext-csd write. Signed-off-by: Avri Altman Acked-by: Adrian Hunter Cc: stable@vger.kernel.org Link: https://lore.kernel.org/r/20210420134641.57343-3-avri.altman@wdc.com Signed-off-by: Ulf Hansson Signed-off-by: Greg Kroah-Hartman --- drivers/mmc/core/block.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) --- a/drivers/mmc/core/block.c +++ b/drivers/mmc/core/block.c @@ -572,6 +572,18 @@ static int __mmc_blk_ioctl_cmd(struct mm } /* + * Make sure to update CACHE_CTRL in case it was changed. The cache + * will get turned back on if the card is re-initialized, e.g. + * suspend/resume or hw reset in recovery. + */ + if ((MMC_EXTRACT_INDEX_FROM_ARG(cmd.arg) == EXT_CSD_CACHE_CTRL) && + (cmd.opcode == MMC_SWITCH)) { + u8 value = MMC_EXTRACT_VALUE_FROM_ARG(cmd.arg) & 1; + + card->ext_csd.cache_ctrl = value; + } + + /* * According to the SD specs, some commands require a delay after * issuing the command. */