Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2496264pxj; Mon, 10 May 2021 04:31:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyoGbghOT8Ky1X08spC8cjwSP4GwltnshARr5bynPgj63WjnWvcMfb+Zl04UhJs77gzHkGu X-Received: by 2002:a05:6402:31b1:: with SMTP id dj17mr28637781edb.7.1620646268214; Mon, 10 May 2021 04:31:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620646268; cv=none; d=google.com; s=arc-20160816; b=TH30vd4ZCBFKXRWVparog5CvTXl9a565I/KDfipAfYwGBn7Nxbiv4ETLcG/0PsMEjz Qh35fIF73R2Lq1k2aThcqk+7mIkBA7udDgswey9CTI2hEEyToBe5llG8XpkCRSlLczt4 lGnIz0SWxtpWDhjBTYtds76ePQSq4VaXGVUE/1xwbDvvQaHXpqMT8JjaT64Efnw5Cpoi aA6T7jlDqSDxuOR/a4Kj7d7xe/JlhzjIDmA5kHtL3dpLIccz36NxZGHSA6wwSmKAXfsP vg+8C2IFsV1k6EFJLq8kaXATuFxPF+SIHCJAjISLlC9dgBrbTeOqNSZxudxSzRqltPu4 sI+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=WgE4myhJig3S8yAbaUTMwFCwl3VNOKRxLZRwiKP5vIs=; b=RTc9AW+E1bkHeA4oKaqDPfgak3V7y/La2ppIZNhWEPuqgoroYg3qWW8gAMxFKNQzxG HjpAGrNPt3VseRH4aJG35fKZtymkfHzgt2kjdHcMA8hI1ueafqsHCX2P+dijym9vHO7x CEYjjcCa6FAgFpwp4Px/tJk/PK+5uj6UyxGAeEk3j3zj0p0P2HeVh8H4QyNMruG0QNtu HwOP+m44BQ3Q3Vk2aoECTUdcHbpNaauJSAgQ6NE2i5LiwRVI6FrFiso+WRvvYlo9eFlQ T/DxEhXdZKNvn4pneOZhQl/7yrS9M34cVoiS005hkMU6cB5mPURPJ+rjmeKakPtT4JaE Vefw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=UYg6w3I+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b15si12653353eds.133.2021.05.10.04.30.44; Mon, 10 May 2021 04:31:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=UYg6w3I+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239468AbhEJL0t (ORCPT + 99 others); Mon, 10 May 2021 07:26:49 -0400 Received: from mail.kernel.org ([198.145.29.99]:52738 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234428AbhEJK4W (ORCPT ); Mon, 10 May 2021 06:56:22 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0F7DC61982; Mon, 10 May 2021 10:46:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1620643563; bh=t6uuShaQBFm1A+tFPwZuHJ2zxR2QAMsD2HA7eO5/v58=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UYg6w3I++q2goc8pnH7F85LWnD380BmAI6QqnE9QO/i0uVgeJchHgWm1nB4Fxrxee u95ylFow4r/N7HOSQpkVRVYZYR0LEdP6zDBaehIWM4JTNd0v6gpyW0xkHEKLr76UFg QrwPsPUaX5qdaM1cDOvdEsyofZhkDLRfDRJ7lQJo= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, David Bauer , Mark Brown , Sasha Levin Subject: [PATCH 5.11 066/342] spi: ath79: remove spi-master setup and cleanup assignment Date: Mon, 10 May 2021 12:17:36 +0200 Message-Id: <20210510102012.303851623@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210510102010.096403571@linuxfoundation.org> References: <20210510102010.096403571@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: David Bauer [ Upstream commit ffb597b2bd3cd78b9bfb68f536743cd46dbb2cc4 ] This removes the assignment of setup and cleanup functions for the ath79 target. Assigning the setup-method will lead to 'setup_transfer' not being assigned in spi_bitbang_init. Because of this, performing any TX/RX operation will lead to a kernel oops. Also drop the redundant cleanup assignment, as it's also assigned in spi_bitbang_init. Signed-off-by: David Bauer Link: https://lore.kernel.org/r/20210303160837.165771-2-mail@david-bauer.net Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- drivers/spi/spi-ath79.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/spi/spi-ath79.c b/drivers/spi/spi-ath79.c index 436327fb58de..98ace748cd98 100644 --- a/drivers/spi/spi-ath79.c +++ b/drivers/spi/spi-ath79.c @@ -156,8 +156,6 @@ static int ath79_spi_probe(struct platform_device *pdev) master->use_gpio_descriptors = true; master->bits_per_word_mask = SPI_BPW_RANGE_MASK(1, 32); - master->setup = spi_bitbang_setup; - master->cleanup = spi_bitbang_cleanup; master->flags = SPI_MASTER_GPIO_SS; if (pdata) { master->bus_num = pdata->bus_num; -- 2.30.2