Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2510634pxj; Mon, 10 May 2021 04:52:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy/OkUB7g4lsZn41103EwiCDEpFucBRMYPYg/EVUS+/iy0DMxBWReyynwNtdyizLEFn6iI9 X-Received: by 2002:a05:6402:1807:: with SMTP id g7mr28593696edy.335.1620647578951; Mon, 10 May 2021 04:52:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620647578; cv=none; d=google.com; s=arc-20160816; b=RpBwWNCvxjp9yi2iXA3S+DO92bNf65r2agl5qAtRkmFeSrc3Imco7wcNBL8nEegGJR QtU7XO7KfylZTwZ1Omjtma1inAoGRB+P/i2yYWHd94k0vA7eiD7LCWzgxtoIkiHg7EVb +8w7mLyYsmEZM8PvzWOBe66w4x+tgIrdQcrwLpHJivplVfoyR9UWP2nSgfo2O7/3Exf7 vZ1e67OIvzoFjvlq439CAE14dz29seqUDob3kJtU2vn69UBJjomkvvv0mP10e+QE36IO 0kcFxrL+/S3rgPGwnGFZ3bqfx7p3NQ6iXtQqwtiIEeO+as4vLMzy4BVxF9x7RIrrgts9 w9Eg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=BO+V9bVKl27mBWVx+dxRj5I7mQI4wfbZvOFP1ZCBmAg=; b=0Nn2A37BtGzM60uaFDKGHF7dnbpVEPDT2zOfeghBUpfegqiDRMiaEvgcDb9z+9iXCX CFaI88bBM/nM4A70qVXVqK5vxR6b/gRfnU74ZTuWNMDbuoJ9solelh5CUNvrSQaMEcyR mGnr4ue+85qDNZhLOzsx6lGbJxSN+0MUvp7ZfyV9zHMHQXd5pPGbOPOoCN0cscXS8e0+ LnN+bCggCjRXK4iaKFnqSK5ju9Pi0HbisoeuoWW0YgN4FW0ek45PA1FYOsQYEwgbT3Wz TnSR91f+0bcnji007kaJf0I6eurLo8TM5THXyg2IeJP0249/fsg1/AyrX3oGQM201ln2 2XIg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=PmDsa1Rg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w9si12586825edq.453.2021.05.10.04.52.32; Mon, 10 May 2021 04:52:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=PmDsa1Rg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242123AbhEJLkt (ORCPT + 99 others); Mon, 10 May 2021 07:40:49 -0400 Received: from mail.kernel.org ([198.145.29.99]:52164 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235042AbhEJK5d (ORCPT ); Mon, 10 May 2021 06:57:33 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 67CD361C41; Mon, 10 May 2021 10:51:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1620643886; bh=bDM2BXsWVu4ZVNspegVRKj6qbKmdCaTTVNDThDY1VSE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PmDsa1RggaEsAZ3+bL7F4tr5ncy1i3Wv7H7oX9ttNWzRYmR5FRTSJMTytUCt+vIbv tSIll0hvUZg93KnRecFJ7WIIqy9Lc8U7PhkrZqDCUzah6nq+Tz1m4eETn86Xj5EAeS L9X9VUz0z94P784+HNDnQpJi40hZ+TrywPjaX7hw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Daniel Wheeler , Dmytro Laktyushkin , Eric Bernstein , Solomon Chiu , Alex Deucher , Sasha Levin Subject: [PATCH 5.11 173/342] drm/amd/display: fix dml prefetch validation Date: Mon, 10 May 2021 12:19:23 +0200 Message-Id: <20210510102015.826915638@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210510102010.096403571@linuxfoundation.org> References: <20210510102010.096403571@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dmytro Laktyushkin [ Upstream commit 8ee0fea4baf90e43efe2275de208a7809f9985bc ] Incorrect variable used, missing initialization during validation. Tested-by: Daniel Wheeler Signed-off-by: Dmytro Laktyushkin Reviewed-by: Eric Bernstein Acked-by: Solomon Chiu Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/display/dc/dml/dcn20/display_mode_vba_20.c | 1 + drivers/gpu/drm/amd/display/dc/dml/dcn20/display_mode_vba_20v2.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn20/display_mode_vba_20.c b/drivers/gpu/drm/amd/display/dc/dml/dcn20/display_mode_vba_20.c index 45f028986a8d..b3f0476899d3 100644 --- a/drivers/gpu/drm/amd/display/dc/dml/dcn20/display_mode_vba_20.c +++ b/drivers/gpu/drm/amd/display/dc/dml/dcn20/display_mode_vba_20.c @@ -3437,6 +3437,7 @@ void dml20_ModeSupportAndSystemConfigurationFull(struct display_mode_lib *mode_l mode_lib->vba.DCCEnabledInAnyPlane = true; } } + mode_lib->vba.UrgentLatency = mode_lib->vba.UrgentLatencyPixelDataOnly; for (i = 0; i <= mode_lib->vba.soc.num_states; i++) { locals->FabricAndDRAMBandwidthPerState[i] = dml_min( mode_lib->vba.DRAMSpeedPerState[i] * mode_lib->vba.NumberOfChannels diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn20/display_mode_vba_20v2.c b/drivers/gpu/drm/amd/display/dc/dml/dcn20/display_mode_vba_20v2.c index 80170f9721ce..1bcda7eba4a6 100644 --- a/drivers/gpu/drm/amd/display/dc/dml/dcn20/display_mode_vba_20v2.c +++ b/drivers/gpu/drm/amd/display/dc/dml/dcn20/display_mode_vba_20v2.c @@ -3510,6 +3510,7 @@ void dml20v2_ModeSupportAndSystemConfigurationFull(struct display_mode_lib *mode mode_lib->vba.DCCEnabledInAnyPlane = true; } } + mode_lib->vba.UrgentLatency = mode_lib->vba.UrgentLatencyPixelDataOnly; for (i = 0; i <= mode_lib->vba.soc.num_states; i++) { locals->FabricAndDRAMBandwidthPerState[i] = dml_min( mode_lib->vba.DRAMSpeedPerState[i] * mode_lib->vba.NumberOfChannels -- 2.30.2