Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2514391pxj; Mon, 10 May 2021 04:59:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxiUzkS/4L0YInFfGW8+8xxeVq7cse3JY7Tqsal2zF/j6vgy9V+/4jVcJT6z86cB+fw0iBf X-Received: by 2002:a05:6638:221:: with SMTP id f1mr21354933jaq.16.1620647956279; Mon, 10 May 2021 04:59:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620647956; cv=none; d=google.com; s=arc-20160816; b=LMbIK/kZ1f7jDavEdg4tQOG5+H2/MAAOxrXZE663kzBIBgwvGLIARx+jRudXYQ4Iro ftgVnL6Xabe6UzX57/BXF59ogKBbWfc6m5lOeZfDF24ZKFFFU3FRceMuUaPl5bncZd5U KnQpLSkzPgs87Ib4yOXbY33TR7RJtT7MPPqbb/N349FlAzroHYrv+ITt2Se9eybkxfi3 FdRV3FTzUXZYwfiE9kIgOMjIRTJIPuBejxEyvL5e0vuhKApnlW7anq00wAqHiw6OUCzW 01KSkczj1Wfe3BYZxiYUNbp0FEvKXQBaUII/c3mco3vb8r8eaqyrMrYNftppzc5gIUsJ FlcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=jnqwtEPfnxQmD7TtiBC83cExiJnxlHKBC3zqopS5YkI=; b=vBBkbjNgs48JhpatuZwmdQQGuwrR6jZydgRqXgiGIi5p5f6lPn4kKJdxPrYxW4nT2o X7aLWtEcdH3IoBTI2pLWPmdODLSAgagaUtpsAyXTIAGLwLtgaLzTG1lfSCRq+iRgl7Tm 9XnYCU8ZnufhG5oqi96bsHdt4gZPbYkxd56UbAif4nLKaCFfLj2cwh7WXqbCHDftTClq e+DehT/BnA1+MTy6TbNauwiGinxbD3ZxXdWhhGGuGGXiw6GEibgFifyqYouTEaXvcxGo pdClkiJ88JAkN+YzQsQN88VDFa3C7FcWfvKKRKBCV8Lm5H81chnRwE3tnLby1mxkR2fX LuxA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=o4AsCKbS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h8si15037643jas.102.2021.05.10.04.58.59; Mon, 10 May 2021 04:59:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=o4AsCKbS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237441AbhEJLw0 (ORCPT + 99 others); Mon, 10 May 2021 07:52:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:36488 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233219AbhEJLBq (ORCPT ); Mon, 10 May 2021 07:01:46 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 62F1D61C50; Mon, 10 May 2021 10:53:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1620644020; bh=HYu738Z9hfd84mR0bu7eMoQor2MK106Intwa8Fm57JE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=o4AsCKbSUZ759o+AH0frD+EZZ3GoeFawhkvNEOpSWUEVIRwMpi3ysTPeUezhwnspD PDg1L3Vr/bzm9q3hNA0pRjLwjlJ7JmQsEm9Uag3EF19a5JqivqCSnFPVCIPFTNwSDO x/ZlxTVXLVGCH5x+cMxbbXYKtE+BACu3TjMSmx4Q= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Luis Henriques , Stefan Hajnoczi , Vivek Goyal , Miklos Szeredi Subject: [PATCH 5.11 256/342] virtiofs: fix memory leak in virtio_fs_probe() Date: Mon, 10 May 2021 12:20:46 +0200 Message-Id: <20210510102018.559834612@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210510102010.096403571@linuxfoundation.org> References: <20210510102010.096403571@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Luis Henriques commit c79c5e0178922a9e092ec8fed026750f39dcaef4 upstream. When accidentally passing twice the same tag to qemu, kmemleak ended up reporting a memory leak in virtiofs. Also, looking at the log I saw the following error (that's when I realised the duplicated tag): virtiofs: probe of virtio5 failed with error -17 Here's the kmemleak log for reference: unreferenced object 0xffff888103d47800 (size 1024): comm "systemd-udevd", pid 118, jiffies 4294893780 (age 18.340s) hex dump (first 32 bytes): 00 00 00 00 ad 4e ad de ff ff ff ff 00 00 00 00 .....N.......... ff ff ff ff ff ff ff ff 80 90 02 a0 ff ff ff ff ................ backtrace: [<000000000ebb87c1>] virtio_fs_probe+0x171/0x7ae [virtiofs] [<00000000f8aca419>] virtio_dev_probe+0x15f/0x210 [<000000004d6baf3c>] really_probe+0xea/0x430 [<00000000a6ceeac8>] device_driver_attach+0xa8/0xb0 [<00000000196f47a7>] __driver_attach+0x98/0x140 [<000000000b20601d>] bus_for_each_dev+0x7b/0xc0 [<00000000399c7b7f>] bus_add_driver+0x11b/0x1f0 [<0000000032b09ba7>] driver_register+0x8f/0xe0 [<00000000cdd55998>] 0xffffffffa002c013 [<000000000ea196a2>] do_one_initcall+0x64/0x2e0 [<0000000008f727ce>] do_init_module+0x5c/0x260 [<000000003cdedab6>] __do_sys_finit_module+0xb5/0x120 [<00000000ad2f48c6>] do_syscall_64+0x33/0x40 [<00000000809526b5>] entry_SYSCALL_64_after_hwframe+0x44/0xae Cc: stable@vger.kernel.org Signed-off-by: Luis Henriques Fixes: a62a8ef9d97d ("virtio-fs: add virtiofs filesystem") Reviewed-by: Stefan Hajnoczi Reviewed-by: Vivek Goyal Signed-off-by: Miklos Szeredi Signed-off-by: Greg Kroah-Hartman --- fs/fuse/virtio_fs.c | 1 + 1 file changed, 1 insertion(+) --- a/fs/fuse/virtio_fs.c +++ b/fs/fuse/virtio_fs.c @@ -896,6 +896,7 @@ static int virtio_fs_probe(struct virtio out_vqs: vdev->config->reset(vdev); virtio_fs_cleanup_vqs(vdev, fs); + kfree(fs->vqs); out: vdev->priv = NULL;